Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 27 Dec 2019 13:47:59 +0100
From:   Michal Kubecek <mkubecek@suse.cz>
To:     netdev@vger.kernel.org
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Jiri Pirko <jiri@resnulli.us>, Andrew Lunn <andrew@lunn.ch>,
        John Linville <linville@tuxdriver.com>,
        Stephen Hemminger <stephen@networkplumber.org>,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v8 14/14] ethtool: provide link state with
 LINKSTATE_GET request
Message-ID: <20191227124759.GK21614@unicorn.suse.cz>
References: <cover.1577052887.git.mkubecek@suse.cz>
 <7a6c4161fc6d29620bdc95a919e03f8be8b91e48.1577052887.git.mkubecek@suse.cz>
 <918da8cd-7ebc-b895-85c8-afad9eed6036@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <918da8cd-7ebc-b895-85c8-afad9eed6036@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 23, 2019 at 08:44:19PM -0800, Florian Fainelli wrote:
> 
> 
> On 12/22/2019 3:46 PM, Michal Kubecek wrote:
> > Implement LINKSTATE_GET netlink request to get link state information.
> > 
> > At the moment, only link up flag as provided by ETHTOOL_GLINK ioctl command
> > is returned.
> > 
> > LINKSTATE_GET request can be used with NLM_F_DUMP (without device
> > identification) to request the information for all devices in current
> > network namespace providing the data.
> > 
> > Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> > ---
> 
> [snip]
> 
> > +Kernel response contents:
> > +
> > +  ====================================  ======  ==========================
> > +  ``ETHTOOL_A_LINKSTATE_HEADER``        nested  reply header
> > +  ``ETHTOOL_A_LINKSTATE_LINK``          u8      autonegotiation status
> 
> ^ ==== Humm, auto-negotiation status may not be exactly accurate
> especially with complex devices with SerDes/PHY/SFPs/what have you/.
> Other than that, the code looks correct:

It seems I forgot to edit this cell text after copy&paste from
LINKMODES_GET above. Fixed in v9, thanks.

Michal

> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> -- 
> Florian