Date: Wed, 25 Jan 2006 13:19:26 +0100
From: Jan Kara <jack@suse.cz>
To: Herbert Poetzl <herbert@13thfloor.at>, Linus Torvalds <torvalds@osdl.org>,
       Andrew Morton <akpm@osdl.org>,
       Linux Kernel ML <linux-kernel@vger.kernel.org>
Subject: Re: [Patch] quota: fix error code for ext2_new_inode()
Message-ID: <20060125121926.GB8640@atrey.karlin.mff.cuni.cz>
References: <20060125064059.GA3778@MAIL.13thfloor.at>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20060125064059.GA3778@MAIL.13thfloor.at>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 967
Lines: 36

  Hi,

> the quota check in ext2_new_inode() returns ENOSPC where
> IMHO it should return EDQUOT instead. here is a trivial
> patch to fix that ...
> 
> rationale: ext3, reiser, udf and ufs do similar checks
> and already return EDQUOT
  Of course, you're right! Andrew please commit this one too.

						Honza


> Signed-off-by: Herbert P?tzl <herbert@13thfloor.at>
  Acked-by: Jan Kara <jack@suse.cz>

> --- ./fs/ext2/ialloc.c.orig	2006-01-03 17:29:56 +0100
> +++ ./fs/ext2/ialloc.c	2006-01-25 07:26:42 +0100
> @@ -605,7 +605,7 @@ got:
>  	insert_inode_hash(inode);
>  
>  	if (DQUOT_ALLOC_INODE(inode)) {
> -		err = -ENOSPC;
> +		err = -EDQUOT;
>  		goto fail_drop;
>  	}
>  
> 
-- 
Jan Kara <jack@suse.cz>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/