Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751145AbWAYMcl (ORCPT ); Wed, 25 Jan 2006 07:32:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751159AbWAYMcl (ORCPT ); Wed, 25 Jan 2006 07:32:41 -0500 Received: from witte.sonytel.be ([80.88.33.193]:45244 "EHLO witte.sonytel.be") by vger.kernel.org with ESMTP id S1751145AbWAYMcj (ORCPT ); Wed, 25 Jan 2006 07:32:39 -0500 Date: Wed, 25 Jan 2006 13:28:51 +0100 (CET) From: Geert Uytterhoeven To: Akinobu Mita cc: Linux Kernel Development , Richard Henderson , Ivan Kokshaysky , Russell King , Ian Molton , dev-etrax@axis.com, David Howells , Yoshinori Sato , Linus Torvalds , linux-ia64@vger.kernel.org, Hirokazu Takata , linux-m68k@vger.kernel.org, Greg Ungerer , Linux/MIPS Development , parisc-linux@parisc-linux.org, Linux/PPC Development , linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Andi Kleen , Chris Zankel Subject: Re: [PATCH 5/6] fix warning on test_ti_thread_flag() In-Reply-To: <20060125113446.GF18584@miraclelinux.com> Message-ID: References: <20060125112625.GA18584@miraclelinux.com> <20060125113446.GF18584@miraclelinux.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1787 Lines: 52 On Wed, 25 Jan 2006, Akinobu Mita wrote: > If the arechitecture is > - BITS_PER_LONG == 64 > - struct thread_info.flag 32 is bits > - second argument of test_bit() was void * > > Then compiler print error message on test_ti_thread_flags() > in include/linux/thread_info.h > > Signed-off-by: Akinobu Mita > --- > thread_info.h | 2 +- > 1 files changed, 1 insertion(+), 1 deletion(-) > > Index: 2.6-git/include/linux/thread_info.h > =================================================================== > --- 2.6-git.orig/include/linux/thread_info.h 2006-01-25 19:07:12.000000000 +0900 > +++ 2.6-git/include/linux/thread_info.h 2006-01-25 19:14:26.000000000 +0900 > @@ -49,7 +49,7 @@ > > static inline int test_ti_thread_flag(struct thread_info *ti, int flag) > { > - return test_bit(flag,&ti->flags); > + return test_bit(flag, (void *)&ti->flags); > } This is not safe. The bitops are defined to work on unsigned long only, so flags should be changed to unsigned long instead, or you should use a temporary. Affected platforms: - alpha: flags is unsigned int - ia64, sh, x86_64: flags is __u32 The only affected 64-platforms are little endian, so it will silently work after your change, though... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/