Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751188AbWAYO4o (ORCPT ); Wed, 25 Jan 2006 09:56:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751190AbWAYO4o (ORCPT ); Wed, 25 Jan 2006 09:56:44 -0500 Received: from ns.virtualhost.dk ([195.184.98.160]:46138 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S1751188AbWAYO4o (ORCPT ); Wed, 25 Jan 2006 09:56:44 -0500 Date: Wed, 25 Jan 2006 15:58:52 +0100 From: Jens Axboe To: Jan Engelhardt Cc: Joerg Schilling , matthias.andree@gmx.de, rlrevell@joe-job.com, linux-kernel@vger.kernel.org Subject: Re: CD writing in future Linux (stirring up a hornets' nest) (was: Rationale for RLIMIT_MEMLOCK?) Message-ID: <20060125145852.GC4212@suse.de> References: <1138039993.2977.62.camel@laptopd505.fenrus.org> <20060123185549.GA15985@merlin.emma.line.org> <43D530CC.nailC4Y11KE7A@burner> <1138048255.21481.15.camel@mindpipe> <20060123212119.GI1820@merlin.emma.line.org> <43D78585.nailD7855YVBX@burner> <20060125142155.GW4212@suse.de> <20060125145544.GA4212@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060125145544.GA4212@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 35 On Wed, Jan 25 2006, Jens Axboe wrote: > On Wed, Jan 25 2006, Jan Engelhardt wrote: > > > > >> And if you check the amount of completely unneeded code Linux currently has > > >> just to implement e.g. SG_IO in /dev/hd*, it could even _save_ space in the > > >> kernel when converting to a clean SCSI based design. > > > > > >Please point me at that huge amount of code. Hint: there is none. > > > > I'm getting a grin: > > > > 15:46 takeshi:../drivers/ide > find . -type f -print0 | xargs -0 grep SG_IO > > (no results) > > > > Looks like it's already non-redundant :) > > SG_IO turns requests into REQ_BLOCK_PC (or blk_pc_request()) types, so > you should probably check for that as well. But it's truly a miniscule > amount of code, and if I got off my ass and folded cdrom_newpc_intr() > and cdrom_pc_intr() into one (that was the intention), it would be even > less. BTW, I should point out that the fact that references to REQ_BLOCK_PC and blk_pc_request() exists doesn't indicate duplicated code. Each low level driver or layer (like SCSI, not the SCSI low level drivers) need to transform REQ_BLOCK_PC requests into their command types. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/