Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: linux-next: Fixes tags need some work in the block tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jaedon Shin <jaedon.shin@gmail.com>
References: <20191228065553.6ba5d28f@canb.auug.org.au>
 <45665759-a76f-5631-51bd-488b04f6bf03@gmail.com>
 <d3ae7893-9b60-ecc2-4a31-65d009ecbb95@kernel.dk>
 <20191228073959.5b3e73b5@canb.auug.org.au>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <3e6975e8-0509-c888-5b90-489ca0f40456@kernel.dk>
Date:   Fri, 27 Dec 2019 13:44:47 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20191228073959.5b3e73b5@canb.auug.org.au>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/27/19 1:39 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Fri, 27 Dec 2019 13:29:40 -0700 Jens Axboe <axboe@kernel.dk> wrote:
>> On 12/27/19 1:27 PM, Florian Fainelli wrote:
>>> On 12/27/2019 11:55 AM, Stephen Rothwell wrote:  
>>>>
>>>> In commit
>>>>
>>>>   1a3d78cb6e20 ("ata: ahci_brcm: BCM7425 AHCI requires AHCI_HFLAG_DELAY_ENGINE")
>>>>
>>>> Fixes tags
>>>>
>>>>   Fixes: 9586114cf1e9 ("ata: ahci_brcmstb: add support MIPS-based platforms")
>>>>   Fixes: 423be77daabe ("ata: ahci_brcmstb: add quirk for broken ncq")
>>>>
>>>> have this problem:
>>>>
>>>>   - Target SHA1s do not exist
>>>>
>>>> Perhaps you meant
>>>>
>>>> Fixes: 1980eb9bd7d7 ("ata: ahci_brcmstb: add support for MIPS-based platforms")
>>>> Fixes: 7de3244530bf ("ata: ahci_brcmstb: disable NCQ for MIPS-based platforms")  
>>>
>>> Yes, those are the two that should have been used, the two commits were
>>> extracted from a downstream tree where the upstream commits ended up
>>> looking slightly different, my script does not (yet) rewrite those, Jens
>>> would you want me to resubmit or can you rewrite the commit message in
>>> place?  
>>
>> It's too late unfortunately, Linus already pulled it. So we'll have to
>> live with it, at least the commit titles are correct so it should be
>> manageable.
> 
> Unfortunately, even the titles are not correct, so they took me a
> little time to find the correct commits :-(  This means it will also
> take the stable maintainers a bit of time.

Yeah I see, the 2nd one is not. Gah, that really sucks. I'll let stable
know.

Florian, please ensure that future submissions have both the right titles
and shas.

-- 
Jens Axboe