Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp11411760ybl;
        Fri, 27 Dec 2019 13:31:36 -0800 (PST)
X-Google-Smtp-Source: APXvYqwrQQ1bBIvXpDXat7mdgzpM6/1CV4XNNUp45CV0qh3A4ekUfMhdNdmvGVQAgW90uNhsRnY2
X-Received: by 2002:aca:4ad5:: with SMTP id x204mr3987299oia.162.1577482296261;
        Fri, 27 Dec 2019 13:31:36 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1577482296; cv=none;
        d=google.com; s=arc-20160816;
        b=k5wIt+yL6NzYIClzj2kka0gEoYuOzvLPZPppn2eNjC3IhdEyKLflmb2hbKMwmrLGdw
         lvFH4bJdYriDUHm6UWAObDkhIvnn7F2AFU9VJHLE8+YD4Iw8kRf15PEogeyjBPGh8726
         B+152j+GpeH2Eke4UHAGzO7YhhH1zrrZccL2OAcIQNwg5MJJkYf+RJBF3mczslzY9zNT
         4ebGiNBlmuwwed6HgaTgC6giTWUV2cTBMRFB3nmCAm4UlINqcpv/O0JGhrOUVUfomYM9
         HetVSCYt5Hz/Mfq3ba1XYQJaxKJu7t0sHD53rFs4YkCooTvO4IEQYlz0lRQ5j72Ce5uu
         84qw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=1s3ZRlg3eLuA98uNtu0u1vLni2lsH91p6tEmhgqylhw=;
        b=pIxkljYTCqKauxqkevIirqnPCrf5weXeDXKqmKBCoo14LQ3cPd8hRBzNypO/VYeoei
         sWLH4uhF2aqrpTme0cNRF4gDJvGgSwGzhLWoA0+JLKXZ7WkAf5CF9SFAgIozRpIg+mR3
         8ybdiQlsxrf7JyyP2ck2yemRgBuMW8MFJ4Da3YEnFdpjBsAedCzxYIYyCGkpC06OI6QH
         r5N8H6N3oCzviDfO19PGB5LYDrsjQoTNzF7A9yAGDobL67oLb8JV00C1N9nPEFkErIL4
         gcWg9m0QE9M53WA6zP5VTqevhVxL+LPaXUo/kghikolP1jh/T1pPeHC8dC2nNDCsRm4v
         gAfw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="b+nDy6/5";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id w64si17266932oif.51.2019.12.27.13.31.24;
        Fri, 27 Dec 2019 13:31:36 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="b+nDy6/5";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726400AbfL0Var (ORCPT <rfc822;tanxianhu@gmail.com> + 99 others);
        Fri, 27 Dec 2019 16:30:47 -0500
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:7227 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725860AbfL0Var (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Dec 2019 16:30:47 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5e0677f80000>; Fri, 27 Dec 2019 13:30:33 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Fri, 27 Dec 2019 13:30:46 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Fri, 27 Dec 2019 13:30:46 -0800
Received: from [10.2.173.37] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 27 Dec
 2019 21:30:43 +0000
Subject: Re: [PATCH v5 07/19] dt-bindings: soc: tegra-pmc: Add id for Tegra
 PMC 32KHz blink clock
To:     Dmitry Osipenko <digetx@gmail.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <broonie@kernel.org>,
        <lgirdwood@gmail.com>, <perex@perex.cz>, <tiwai@suse.com>,
        <mperttunen@nvidia.com>, <gregkh@linuxfoundation.org>,
        <sboyd@kernel.org>, <robh+dt@kernel.org>, <mark.rutland@arm.com>
CC:     <pdeschrijver@nvidia.com>, <pgaikwad@nvidia.com>,
        <spujar@nvidia.com>, <josephl@nvidia.com>,
        <daniel.lezcano@linaro.org>, <mmaddireddy@nvidia.com>,
        <markz@nvidia.com>, <devicetree@vger.kernel.org>,
        <linux-clk@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1576880825-15010-1-git-send-email-skomatineni@nvidia.com>
 <1576880825-15010-8-git-send-email-skomatineni@nvidia.com>
 <c8a847fb-3d23-6e1e-59e2-a2d15b63ce02@gmail.com>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <b46c21ca-855e-cd81-ab8d-aa96b61ebb56@nvidia.com>
Date:   Fri, 27 Dec 2019 13:30:43 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <c8a847fb-3d23-6e1e-59e2-a2d15b63ce02@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1577482233; bh=1s3ZRlg3eLuA98uNtu0u1vLni2lsH91p6tEmhgqylhw=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=b+nDy6/5A6GRzEUimt6Var6U6fQv34a8k3GLOuEB7/RmK8nruLnbuSgmzNLma/mMR
         kgHZGfW99Nw9z7eI67wjRwWZHNJ8LbpwNu+gQ3TxzK5bez7JWF1CTX7J5soUs2lFnW
         0WrThuFTNG1Ci69NrQcy2Eoq5+qoDtPtiUG0uI3TQPwzfhLAmBN8RMuxuoHLd7XB9u
         rYZl1/xGRyj3ZoS8/d6pseAEtcpkUE3uZKLAWr3DxyVk832WcXld9ll7tc2XgOelqN
         kSgrQY/sFMWIY9/Z9fu+vsyf0LQ6/SatkJQ0q5ce1MKXqvstbDlK0ZCOIB82aDXCoc
         03/0Xbb3LZ7Nw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/22/19 1:55 PM, Dmitry Osipenko wrote:
> 21.12.2019 01:26, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> Tegra PMC has blink functionality that allows 32KHz clock out to
>> blink pin of the Tegra.
>>
>> This patch adds id for this blink clock to use for enabling or
>> disabling blink output through device tree.
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>>   include/dt-bindings/soc/tegra-pmc.h | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/soc/tegra-pmc.h b/include/dt-bindings/s=
oc/tegra-pmc.h
>> index f7c866404456..a99a457471ee 100644
>> --- a/include/dt-bindings/soc/tegra-pmc.h
>> +++ b/include/dt-bindings/soc/tegra-pmc.h
>> @@ -9,7 +9,8 @@
>>   #define TEGRA_PMC_CLK_OUT_1		0
>>   #define TEGRA_PMC_CLK_OUT_2		1
>>   #define TEGRA_PMC_CLK_OUT_3		2
>> +#define TEGRA_PMC_CLK_BLINK		3
>>  =20
>> -#define TEGRA_PMC_CLK_MAX		3
>> +#define TEGRA_PMC_CLK_MAX		4
>>  =20
>>   #endif	/* _DT_BINDINGS_SOC_TEGRA_PMC_H */
>>
> Could you please explain the reason of separating CLK_OUT and BLINK PMC
> patches?
No specific reason just thought to have BLINK as separate patch as its=20
different register configuration to have fixed 32Khz clock out.
>
> Also, you only documented CLK_OUT clocks in the DT binding and no BLINK.
missed to add BLINK to dt-binding doc. Will add in v6.