Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 27 Dec 2019 14:57:26 -0800
From:   Moritz Fischer <mdf@kernel.org>
To:     yu kuai <yukuai3@huawei.com>
Cc:     hao.wu@intel.com, mdf@kernel.org, linux-fpga@vger.kernel.org,
        linux-kernel@vger.kernel.org, yi.zhang@huawe.com,
        zhengbin13@huawei.com
Subject: Re: [PATCH] fpga: dfl: fme: remove set but not used variable 'fme'
Message-ID: <20191227225726.GA1643@archbook>
References: <20191226121638.10507-1-yukuai3@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191226121638.10507-1-yukuai3@huawei.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 26, 2019 at 08:16:38PM +0800, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/fpga/dfl-fme-main.c: In function ‘fme_dev_destroy’:
> drivers/fpga/dfl-fme-main.c:678:18: warning: variable ‘fme’ set but not
> used [-Wunused-but-set-variable]
> 
> It is never used and so can be removed.
> 
> Signed-off-by: yu kuai <yukuai3@huawei.com>
> ---
>  drivers/fpga/dfl-fme-main.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
> index 7c930e6b314d..1d4690c99268 100644
> --- a/drivers/fpga/dfl-fme-main.c
> +++ b/drivers/fpga/dfl-fme-main.c
> @@ -675,10 +675,8 @@ static int fme_dev_init(struct platform_device *pdev)
>  static void fme_dev_destroy(struct platform_device *pdev)
>  {
>  	struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
> -	struct dfl_fme *fme;
>  
>  	mutex_lock(&pdata->lock);
> -	fme = dfl_fpga_pdata_get_private(pdata);
>  	dfl_fpga_pdata_set_private(pdata, NULL);
>  	mutex_unlock(&pdata->lock);
>  }
> -- 
> 2.17.2
> 
Acked-by: Moritz Fischer <mdf@kernel.org>

Thanks,
Moritz