Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp11552013ybl; Fri, 27 Dec 2019 16:32:53 -0800 (PST) X-Google-Smtp-Source: APXvYqzzXmP2x3mzE/ypd+E3I458Hj/ppurJO26PboAdvFEr85eTx/jsr69WIcYScevw6V/LODA+ X-Received: by 2002:a9d:c02:: with SMTP id 2mr61250743otr.183.1577493173389; Fri, 27 Dec 2019 16:32:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577493173; cv=none; d=google.com; s=arc-20160816; b=zFwVFnJFziB9YnC7weJTVX3DcGSueJgywTiwZkv7OfS8vDSmhYRSVIIM5rVu1WpnVQ sP5ugYcoep51srami0peSPdX3s/FNzQrIkTLbbna4dZ6GzBNAs1o2nF0hHULPbeCaqrA nKT7YBWKYszfHrbOFvmYX/+yOSLEIy1aNQDPFVAA4g2diUcZ3GjDlM/sfEqYZ/xBwIQU V6el7h+dHw2Vo4uBVio9AbBAq/FFm28eP5HbJBtiNsJJb8A4U/AuJueVWehok/bAjTIc IZQyEtkHvQOG+lTTXyjiFKd/EbWCbHZD+qrJksdn15HPIrhu3RG+/72+8mUAIvu226ts RsSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=nEa/k+/SNmNq348CDpyX037YrdBl+ZN8tPEnVTvOrvg=; b=g35lqZAwdE/Z1vq6JSAaMmYSAEoBXwJ+s+8Y1ovSHu/bAxNpn2KvOfEeuVxE8J/ENO N4MbZ+cPZq1fmIZiPCBh71VgzKfeKuBtL3cFHqBV/UTnpVZDHwPzGNjN1NzwQR696xi5 pjMAPkdEtt8WJZrj0JBeIc295V7jFVz62fyFbbbpfhKNCgoRHbS136H0sDYUocc3WxM8 WdjHXDW9eTS1sw62m+1eJhQdLUZiIozWHwjxui7sKxzSrT3vuJSRjcI1zQTodFHYrIa3 JxVFyzbDIufdYpGuQyuIcSkfAaNGCxy1bKGDIK9WsWRQPBHx5KVqCKb+pzkXtbItojtC lDFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t20si18722363otr.64.2019.12.27.16.32.27; Fri, 27 Dec 2019 16:32:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbfL1AbP (ORCPT + 99 others); Fri, 27 Dec 2019 19:31:15 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:53716 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbfL1AbP (ORCPT ); Fri, 27 Dec 2019 19:31:15 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 23818154D1147; Fri, 27 Dec 2019 16:31:14 -0800 (PST) Date: Fri, 27 Dec 2019 16:31:13 -0800 (PST) Message-Id: <20191227.163113.718146091776171084.davem@davemloft.net> To: vulab@iscas.ac.cn Cc: paulus@samba.org, linux-ppp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ppp: Remove redundant BUG_ON() check in ppp_pernet From: David Miller In-Reply-To: <1577180224-16405-1-git-send-email-vulab@iscas.ac.cn> References: <1577180224-16405-1-git-send-email-vulab@iscas.ac.cn> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Dec 2019 16:31:14 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xu Wang Date: Tue, 24 Dec 2019 09:37:04 +0000 > Passing NULL to ppp_pernet causes a crash via BUG_ON. > Dereferencing net in net_generici() also has the same effect. > This patch removes the redundant BUG_ON check on the same parameter. > > Signed-off-by: Xu Wang Applied, thanks.