Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp11552220ybl; Fri, 27 Dec 2019 16:33:07 -0800 (PST) X-Google-Smtp-Source: APXvYqwzCqdKjekvQjjn/mEbaa84WswKgFVi1zBdxmofRx8RcAiUokh6viqPesrV7pgUMdftkhMn X-Received: by 2002:a9d:7b50:: with SMTP id f16mr61553450oto.18.1577493187057; Fri, 27 Dec 2019 16:33:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577493187; cv=none; d=google.com; s=arc-20160816; b=uoAPjF9LGPGXx19vi25z4L6D4XtfwCAfvpQleXpzWZtExLAg3tI54RJoHITmaxbdd9 l/WY0LFDL+22cKwHosisYksz4v3lmvm/n0YOORCfPbpaZ5FKGMIuv/an1EziLJg+1vYV Ey1jbGrOrexLzP6ClqGP/XlggXHOGwwj6xJ4djQzoTp92jRr8wEF/ieHEH5AnmJdysSq RGR7IXPdt0KxfFBrics66+9CLnceIuw24uYYoxtqGscEqGiwmtveW/0I2ja5sLu+JUoO f5GItUn6a+i3TPff5BT93SUbw5sqy5zP/cxmwHtK+8yti5Tgd0dAMqENPzEenW2wixTr 3SNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=bEIR8EgLoaI1iRBe8qoJrkP5jF/+0WTB7K5a9UA+bQY=; b=o4Oc3LxmCXQmE5sRPkr39c4GIgdsQIO4ZAHSRE1YC3ADiAeCKGVA5UXEyWCwUr+9wf Zp7M5hN6dVtifT7OJh6g5Nsr1NB5CSHIDTbCmhuq8hsvsXiKw6Z2I3zPHN4uELBd8Yx+ jR+aEchkLDPnMrymsp+n+reSpIdFe5KC0qryWsEYsLTCDWce1nWzTEnfpj/FMuzZnalA 7OrGbql7Xe6bwUhfGJHd98YOjw7hJUukwF93ijYmeXirue9Qf34bh5wwGQKpbWLm1d5W coOLnfa+ON5/lugrW/Z08Is/Ii7rgw4Wzt6JLhNvXN74745RV7cr4gLmPSnJxEXYXZT4 rm1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l131si17740979oig.120.2019.12.27.16.32.56; Fri, 27 Dec 2019 16:33:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726423AbfL1AcT (ORCPT + 99 others); Fri, 27 Dec 2019 19:32:19 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:53730 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbfL1AcS (ORCPT ); Fri, 27 Dec 2019 19:32:18 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 22BA5154D114C; Fri, 27 Dec 2019 16:32:18 -0800 (PST) Date: Fri, 27 Dec 2019 16:32:17 -0800 (PST) Message-Id: <20191227.163217.1055599246835779278.davem@davemloft.net> To: maowenan@huawei.com Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, linux@rempel-privat.de, marek.behun@nic.cz, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_init From: David Miller In-Reply-To: <20191224115812.166927-1-maowenan@huawei.com> References: <20191224112515.GE3395@lunn.ch> <20191224115812.166927-1-maowenan@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Dec 2019 16:32:18 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mao Wenan Date: Tue, 24 Dec 2019 19:58:12 +0800 > There is no need to set variable 'mbus' static > since new value always be assigned before use it. > > Signed-off-by: Mao Wenan Applied, thank you.