Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 27 Dec 2019 22:04:09 -0800 (PST)
From:   Paul Walmsley <paul.walmsley@sifive.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
cc:     linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
        kbuild test robot <lkp@intel.com>,
        Christoph Hellwig <hch@lst.de>,
        Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH] riscv: fix compile failure with EXPORT_SYMBOL() & !MMU
In-Reply-To: <20191222092604.92217-1-luc.vanoostenryck@gmail.com>
Message-ID: <alpine.DEB.2.21.9999.1912272203260.194339@viisi.sifive.com>
References: <20191222092604.92217-1-luc.vanoostenryck@gmail.com>
User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 22 Dec 2019, Luc Van Oostenryck wrote:

> When support for !MMU was added, the declaration of
> __asm_copy_to_user() & __asm_copy_from_user() were #ifdefed
> out hence their EXPORT_SYMBOL() give an error message like:
>   .../riscv_ksyms.c:13:15: error: '__asm_copy_to_user' undeclared here
>   .../riscv_ksyms.c:14:15: error: '__asm_copy_from_user' undeclared here
> 
> Since these symbols are not defined with !MMU it's wrong to export them.
> Same for __clear_user() (even though this one is also declared in
> include/asm-generic/uaccess.h and thus doesn't give an error message).
> 
> Fix this by doing the EXPORT_SYMBOL() directly where these symbols
> are defined: inside lib/uaccess.S itself.
> 
> Fixes 6bd33e1ece528f67646db33bf97406b747dafda0
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

Thanks Luc; queued for v5.5-rc.


- Paul