Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp11997420ybl; Sat, 28 Dec 2019 03:14:32 -0800 (PST) X-Google-Smtp-Source: APXvYqzi0hNDDhJ+Ewfm0ovcxonZvKx6fuyNas6zs8hZFx3Fw4zJvmhC6p82ZWTis6/oPybQTCg/ X-Received: by 2002:a05:6830:1689:: with SMTP id k9mr64388838otr.311.1577531672542; Sat, 28 Dec 2019 03:14:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577531672; cv=none; d=google.com; s=arc-20160816; b=ABML+DOvKZjQmCFy7t2+FMBvAf/7D+TfLXJbEdFNOIBL9c7BHvZ8gG8R3g4ziSv/OB 7ZApkA+H3mAGdSmjdenq/2W2UTEuN5BdLeG966CpQonAoAsVl6vsZyUY1rLwBKHEVw0c 3VSQR+PY+IrxCQnM0b+phqjaoqjGnTkuED5P3vdrrKuu2RcOrkDl4bZxSFiQJCxjCR22 8+h+kdWIIrU6nl3ofTkbA3I1t+NYZLu7aoxFuoHiNq4WCqHwpuTeo/6Qi3l6PHBBI7A5 08dqGC5vWf+ew5WTF8p4IJWmSGQjHNRNod4joz3pt55xWRBg7mIzl6+aYN8wmp9jPqto lacg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=KElmZM5dkNAHQpTzzrjHnML4RPBEKGzTVPP1i0RJr8E=; b=rMtetJM84W6FG6HGPE/sQzNVla0FUockFBv0RuWQDswCF2Idn0b8sbqVIkqSD/hCFT VnVNOylJjd7TFQfaYBdZi1e7kX4YS++lXv0gW+VBAbs6oju//ecURcCNSIuiG0Ml2uGA YfPj3RVLyLT19ls6JrRYeCZARkXK9p30C7lRJp/Jb+vbH4JoVsqPEADQxUP6YEB0ewu4 wSzQ8G9Y2sbBakfaVw5p43WDaRiTA0CxfZ7gJyIWZcrw7Xx4NVit4crYF/YdVsyTAt5p /cNRp8dxXmQKTZCKZG1v3wIDjdNl2hPn+VOeoyQ3PW1wC7HV2ziqBJaEu5f2ncWiWdTt f2+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZeVIBTUe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z22si11737362otq.94.2019.12.28.03.14.20; Sat, 28 Dec 2019 03:14:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZeVIBTUe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726395AbfL1LNl (ORCPT + 99 others); Sat, 28 Dec 2019 06:13:41 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:40616 "EHLO mail-wm1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbfL1LNk (ORCPT ); Sat, 28 Dec 2019 06:13:40 -0500 Received: by mail-wm1-f41.google.com with SMTP id t14so10273166wmi.5; Sat, 28 Dec 2019 03:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=KElmZM5dkNAHQpTzzrjHnML4RPBEKGzTVPP1i0RJr8E=; b=ZeVIBTUeg+eAWruRVTTD2sDc52dRhuO1XtufRbTQ6WWy3kCgKjw+SSwflPcflZ/IzK j4Z5XNY0kaU43IoTsXvWJXDd65wQMAJiqQwtyjMAeGrEdLkwhHok45Ce3Kx7nFkJV4us xmrssh1k7RteUSB2MAXLhUn9UW/MwAPumOPG6fX1Cj874GB2V/cua6XwYiFZdcsiBBeE knB0ejaTWScka1/aciLT+4YCa5j2h7QjHRDfeCxEb+sUTDgRE5BX/lh68J2a79sBckFb 0o2jJHC8zR2xtC+luLHOXz5UW6Q55s2ct0u4+Sq3XprSRDEtG02/F97zWlTK4pzgETZg Qg8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KElmZM5dkNAHQpTzzrjHnML4RPBEKGzTVPP1i0RJr8E=; b=co2Ygu9080BoyNtF/gzCIPA9ximJa5vtPmwx5PPYrIdNTGTmf9+zqQxgyZnpb7qxqG tsSfwZr3e4neZ5bwCfrTUqKW11mbPpp11U/KHJ8cmyj1v0B8ntXZCelRxSWL7AY3Dgm2 K/liNeTtCx0WnmW1j42+B7KSpUMf1d9c28V7O1tPCeOx2J1qimo7IfTM5J+eb/HLeQmm XL/b2dHWA4KtaD6lm/6oKXpMdfY7wQ3ka/aOXxhVfozTArxIIjWdcZCRWYO/hh5MI8rc TTfwt9/PJnnUi5W6hBont2INyEl1kaNFyRtivLDDAcJ8dEoXxtltuinpH3EbNqGz10aZ ycPg== X-Gm-Message-State: APjAAAUALNUVVTAnfYP+fTYDtTdyd4ZLV+0caLYg6N617VSJa/fz3tE9 guA+Wo8sANHIi3JRq0uXIl9zRRkI X-Received: by 2002:a1c:f009:: with SMTP id a9mr23143964wmb.73.1577531618221; Sat, 28 Dec 2019 03:13:38 -0800 (PST) Received: from localhost.localdomain ([109.126.145.157]) by smtp.gmail.com with ESMTPSA id q11sm37432622wrp.24.2019.12.28.03.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Dec 2019 03:13:37 -0800 (PST) From: Pavel Begunkov To: Jens Axboe , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 0/2] optimise ctx's refs grabbing in io_uring Date: Sat, 28 Dec 2019 14:13:01 +0300 Message-Id: X-Mailer: git-send-email 2.24.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Optimise percpu_ref_tryget() by not calling it for each request, but batching it. This gave a measurable ~5% performance boost for large QD. v2: fix uncommited plug (Jens Axboe) better comments for percpu_ref_tryget_many (Dennis Zhou) amortise across io_uring_enter() boundary v3: drop "batching across syscalls" remove error handling in io_submit_sqes() from common path v4: fix error handling Pavel Begunkov (2): pcpu_ref: add percpu_ref_tryget_many() io_uring: batch getting pcpu references fs/io_uring.c | 26 +++++++++++++++++--------- include/linux/percpu-refcount.h | 26 +++++++++++++++++++++----- 2 files changed, 38 insertions(+), 14 deletions(-) -- 2.24.0