Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp12716710ybl; Sat, 28 Dec 2019 19:36:43 -0800 (PST) X-Google-Smtp-Source: APXvYqy+8oc5GHcmCg4q+76226dAevWumcuN++JXx7ahAJdh6b5eL22ImvHU7sh22xW/mTO5dufA X-Received: by 2002:a9d:7ada:: with SMTP id m26mr68267631otn.111.1577590603130; Sat, 28 Dec 2019 19:36:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577590603; cv=none; d=google.com; s=arc-20160816; b=fRjysSppmelQdJ4rSfY1QQao3fHBk/UMrKGu4e3PEzhlqw4VGaFS/IzaTDsA/BAHS4 qZp0uffpeaX5RUEdiqNW42g41GgCGOiVE6G4gePU30kbJrTx3nCpOm9ou9qMFHb7QFeF 8b0wapH+Wsv/O12N9tIFPNxu/7wB+nf+ZBTGTlcVG+kKdC1n9RpX379JEzp8zjeMJ5X9 1hgmTHC6kE/g4UZRwWkpjXcx+yelaUmVnv0+AdiYjjjJJ/5y+ZdL6HtTd8/cUWvQ+jzj X/LSz+jfUTMQho/sLrg4KT403XKyRpM1zx8xYAkzegRReQhvzoDnuEU9j9+xkS1CMBPm GYIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=mPy3u4+QpRgdQYQ9Mp1NkaSkxalaThVlLa9KXxTz7Ew=; b=f29Br2zltGewhWdB5/Zf72QI+Y0QX2qzE/lpPw5sLWhtkNVebnlt8in+a1c+qmSgd7 2ElMeqgYvuF7U741skQboK/aTBBGWF2poinCOlMWPBaadNEMa3QDqzHe6vEYGERnQb++ 3HZ7opraMvN5FRL9Lp8NNXLqIDo429hR9eUj+PiPF1IguiPj8E6C3CriaAKrLLFa+IYx F53BqXAyKSksAXI/Vbc/e/QEsjgjh7HA4k8sXVofqTfL9RnUsmRU+8wuMN/CSI/r94Aq M/myIDY5PG3SCTMF3ijuBnr7G1GbCZa4I9VojkJ4xnjVrkI44BoSWt7PQ7YPiEhgC+am OBoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QD9ypE87; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l14si19034786oii.37.2019.12.28.19.36.31; Sat, 28 Dec 2019 19:36:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QD9ypE87; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726371AbfL2Dfe (ORCPT + 99 others); Sat, 28 Dec 2019 22:35:34 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:46695 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726359AbfL2Dfe (ORCPT ); Sat, 28 Dec 2019 22:35:34 -0500 Received: by mail-pg1-f193.google.com with SMTP id z124so16425265pgb.13 for ; Sat, 28 Dec 2019 19:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mPy3u4+QpRgdQYQ9Mp1NkaSkxalaThVlLa9KXxTz7Ew=; b=QD9ypE87A8v3ue0tIqTrH58ucVhmQHzMSX98LP8WrAkrOFprag+vQmQtsvovWYRHOa Z46L9sDfdQTq9Pwwa7DJ+uLxTPQEhohIvBrVoXuJ/xHhx4OEZD/9qea6X3QcIq2Q8rEo 1UGBgmYBrsXiO7d+Q14Zuyyt13FRsi31CxCSWdm+0hSTz6zBA0btMNBSgQmMjbx1KRCZ +gYKUqM4QPVamvcNsTl5Ojm7IIMe8iw5e4DlvfGqbeXQkomZD1/v7+McOUelPf3B9OGd qEVL4nWrf+kyMu9wc9W4nx6w3/2w3gUUz/HiYo5ndU+Wmw2nNS6qVAlPoDVqBfpeXwVQ kdDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mPy3u4+QpRgdQYQ9Mp1NkaSkxalaThVlLa9KXxTz7Ew=; b=pgMsSCePvUJShr852FOWghC8oMqlRLdaQnZMdYOq433YinmoS3EWO1kVXcVQEgx6os QOHCf/m7vQe20/9qwFHD4pPl8EyFF9U6iRwVln8GrYZXYQbWU8yD/e8dI/SQrNd2jXKZ JKjVSBAgv4aC5pKqMvzLuWCTA4T7PSY8UQgI5AjQgrcP6Fcl0TLepyyiW0pCUoLeibP/ 280gUEw+Ziyg/KfTKJY9mi6gh7qKPfA+TNFt8VWR/E75eDEi65dN0F2W8eR2lNAUPvTC BEmCQOBM3uoC2zXLAAYMnD1kwM/nRjYab6V/z46gZHHQIMStXiwgYxykm8SQdtVbhWA7 YvVw== X-Gm-Message-State: APjAAAU7sud+/Cxiw4vrmJnigvloQO7PUS3jWFiBZvCqyq8SAEGF9NKK vGmymSrutfLv8hPSXNwGENkUmA== X-Received: by 2002:a65:5788:: with SMTP id b8mr63501355pgr.324.1577590533167; Sat, 28 Dec 2019 19:35:33 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id d22sm44458904pfo.187.2019.12.28.19.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Dec 2019 19:35:32 -0800 (PST) Date: Sat, 28 Dec 2019 19:35:30 -0800 From: Bjorn Andersson To: Sricharan R Cc: agross@kernel.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org, robh+dt@kernel.org, sboyd@kernel.org, sivaprak@codeaurora.org Subject: Re: [PATCH V2 2/7] pinctrl: qcom: Add ipq6018 pinctrl driver Message-ID: <20191229033530.GN3755841@builder> References: <1576752109-24497-1-git-send-email-sricharan@codeaurora.org> <1576752109-24497-3-git-send-email-sricharan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1576752109-24497-3-git-send-email-sricharan@codeaurora.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 19 Dec 02:41 PST 2019, Sricharan R wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-ipq6018.c b/drivers/pinctrl/qcom/pinctrl-ipq6018.c [..] > +static const struct msm_function ipq6018_functions[] = { [..] > + FUNCTION(qpic_pad), > + FUNCTION(qpic_pad0), > + FUNCTION(qpic_pad1), > + FUNCTION(qpic_pad2), > + FUNCTION(qpic_pad3), > + FUNCTION(qpic_pad4), > + FUNCTION(qpic_pad5), > + FUNCTION(qpic_pad6), > + FUNCTION(qpic_pad7), > + FUNCTION(qpic_pad8), Shouldn't the qpic_padN entries be removed now? (Please double check the rest as well) [..] > + > +static const struct msm_pingroup ipq6018_groups[] = { > + PINGROUP(0, qpic_pad, wci20, qdss_traceclk_b, _, burn0, _, _, _, _), > + PINGROUP(1, qpic_pad, mac12, qdss_tracectl_b, _, burn1, _, _, _, _), > + PINGROUP(2, qpic_pad, wci20, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(3, qpic_pad, mac01, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(4, qpic_pad, mac01, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(5, qpic_pad, mac21, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(6, qpic_pad, mac21, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(7, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(8, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(9, qpic_pad, atest_char, cxc0, mac13, dbg_out, qdss_tracedata_b, _, _, _), > + PINGROUP(10, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(11, qpic_pad, wci22, mac12, qdss_tracedata_b, _, _, _, _, _), > + PINGROUP(12, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(13, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(14, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(15, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(16, qpic_pad, cxc0, mac13, qdss_tracedata_b, _, _, _, _, _), > + PINGROUP(17, qpic_pad, qdss_tracedata_b, wci22, _, _, _, _, _, _), Regards, Bjorn