Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   =?iso-8859-1?Q?J=E9r=F4me_Pouiller?= <Jerome.Pouiller@silabs.com>
To:     Matthew Hanzelik <mrhanzelik@gmail.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH v2] Staging: wfx: Fix style issues with hif_rx.c
Thread-Topic: [PATCH v2] Staging: wfx: Fix style issues with hif_rx.c
Thread-Index: AQHVvRcqbYTdpmaFvEWONRccZN89safQ36YA
Date:   Sun, 29 Dec 2019 09:47:01 +0000
Message-ID: <3570432.mCMjMbKv1p@pc-42>
References: <20191228003818.mmcf4aasks5mqcnr@mandalore.localdomain>
In-Reply-To: <20191228003818.mmcf4aasks5mqcnr@mandalore.localdomain>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: silabs.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <346F119007CB444EA7109F8C5332BF9A@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f2c2696-bc9a-4a2b-ab9e-08d78c440e33
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2019 09:47:01.8327
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UGht1wAH6cbXiiK391hircgdlU62KUYbnPpkrj+vye1arsBiDajwzwi+LCzCuKXPtgAxf6ARhMGRhZrxsFJ4yg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4416
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday 28 December 2019 01:38:24 CET Matthew Hanzelik wrote:
> Fixes the 80 character line limit warning on line 79 of hif_rx.c.
>=20
> Also fixes the missing blank line warning on line 305 of hif_rx.c after
> the declaration of size_t len.
>=20
> Signed-off-by: Matthew Hanzelik <mrhanzelik@gmail.com>
> ---
> Changes in v2:
>  - Make the commit message less vague.
>=20
>  drivers/staging/wfx/hif_rx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c
> index 820de216be0c..1da9a153dda0 100644
> --- a/drivers/staging/wfx/hif_rx.c
> +++ b/drivers/staging/wfx/hif_rx.c
> @@ -76,7 +76,8 @@ static int hif_multi_tx_confirm(struct wfx_dev *wdev, s=
truct hif_msg *hif,
>                                 void *buf)
>  {
>         struct hif_cnf_multi_transmit *body =3D buf;
> -       struct hif_cnf_tx *buf_loc =3D (struct hif_cnf_tx *) &body->tx_co=
nf_payload;
> +       struct hif_cnf_tx *buf_loc =3D (struct hif_cnf_tx *)
> +                                     &body->tx_conf_payload;

Since cast operator is an unary operator, I would try to avoid line break
between cast and variable. I suggest to place the break after the '=3D'.


>         struct wfx_vif *wvif =3D wdev_to_wvif(wdev, hif->interface);
>         int count =3D body->num_tx_confs;
>         int i;
> @@ -302,6 +303,7 @@ static int hif_exception_indication(struct wfx_dev *w=
dev,
>                                     struct hif_msg *hif, void *buf)
>  {
>         size_t len =3D hif->len - 4; // drop header
> +
>         dev_err(wdev->dev, "firmware exception\n");
>         print_hex_dump_bytes("Dump: ", DUMP_PREFIX_NONE, buf, len);
>         wdev->chip_frozen =3D 1;
Ack.

--=20
J=E9r=F4me Pouiller