Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yangtao Li <tiny.windzz@gmail.com>
To:     corbet@lwn.net, gregkh@linuxfoundation.org,
        bgolaszewski@baylibre.com, arnd@arndb.de, sboyd@kernel.org,
        mchehab+samsung@kernel.org, matti.vaittinen@fi.rohmeurope.com,
        phil.edworthy@renesas.com, suzuki.poulose@arm.com,
        saravanak@google.com, heikki.krogerus@linux.intel.com,
        dan.j.williams@intel.com, joe@perches.com,
        jeffrey.t.kirsher@intel.com, mans@mansr.com, tglx@linutronix.de,
        hdegoede@redhat.com, akpm@linux-foundation.org,
        ulf.hansson@linaro.org, ztuowen@gmail.com,
        sergei.shtylyov@cogentembedded.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Yangtao Li <tiny.windzz@gmail.com>
Subject: [PATCH] platform: goldfish: pipe: switch to platform_get_irq
Date:   Sun, 29 Dec 2019 10:43:24 +0000
Message-Id: <20191229104325.10132-2-tiny.windzz@gmail.com>
In-Reply-To: <20191229104325.10132-1-tiny.windzz@gmail.com>
References: <20191229104325.10132-1-tiny.windzz@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it
was not retrieved earlier.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 drivers/platform/goldfish/goldfish_pipe.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index cef0133aa47a..a1ebaec6eea9 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -913,11 +913,9 @@ static int goldfish_pipe_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-	if (!r)
-		return -EINVAL;
-
-	dev->irq = r->start;
+	dev->irq = platform_get_irq(pdev, 0);
+	if (dev->irq < 0)
+		return dev->irq;
 
 	/*
 	 * Exchange the versions with the host device
-- 
2.17.1