Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191229104325.10132-1-tiny.windzz@gmail.com> <20191229104325.10132-2-tiny.windzz@gmail.com>
In-Reply-To: <20191229104325.10132-2-tiny.windzz@gmail.com>
From:   Frank Lee <tiny.windzz@gmail.com>
Date:   Sun, 29 Dec 2019 18:44:54 +0800
Message-ID: <CAEExFWujEpQ0F4bGi9Z94=ymRh5nx_3ftwUZfwLhPvaAbHNCrw@mail.gmail.com>
Subject: Re: [PATCH] platform: goldfish: pipe: switch to platform_get_irq
To:     Jonathan Corbet <corbet@lwn.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        bgolaszewski@baylibre.com, Arnd Bergmann <arnd@arndb.de>,
        Stephen Boyd <sboyd@kernel.org>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        matti.vaittinen@fi.rohmeurope.com, phil.edworthy@renesas.com,
        suzuki.poulose@arm.com, saravanak@google.com,
        heikki.krogerus@linux.intel.com, dan.j.williams@intel.com,
        Joe Perches <joe@perches.com>, jeffrey.t.kirsher@intel.com,
        mans@mansr.com, tglx@linutronix.de, hdegoede@redhat.com,
        Andrew Morton <akpm@linux-foundation.org>,
        Ulf Hansson <ulf.hansson@linaro.org>, ztuowen@gmail.com,
        sergei.shtylyov@cogentembedded.com, linux-doc@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Ignore this, I posted it just now...

On Sun, Dec 29, 2019 at 6:43 PM Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
> requesting IRQ's resources, as they can be not ready yet. Using
> platform_get_irq() instead is preferred for getting IRQ even if it
> was not retrieved earlier.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
>  drivers/platform/goldfish/goldfish_pipe.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
> index cef0133aa47a..a1ebaec6eea9 100644
> --- a/drivers/platform/goldfish/goldfish_pipe.c
> +++ b/drivers/platform/goldfish/goldfish_pipe.c
> @@ -913,11 +913,9 @@ static int goldfish_pipe_probe(struct platform_device *pdev)
>                 return -EINVAL;
>         }
>
> -       r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> -       if (!r)
> -               return -EINVAL;
> -
> -       dev->irq = r->start;
> +       dev->irq = platform_get_irq(pdev, 0);
> +       if (dev->irq < 0)
> +               return dev->irq;
>
>         /*
>          * Exchange the versions with the host device
> --
> 2.17.1
>