Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191229104325.10132-1-tiny.windzz@gmail.com> <20191229104325.10132-3-tiny.windzz@gmail.com>
In-Reply-To: <20191229104325.10132-3-tiny.windzz@gmail.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Sun, 29 Dec 2019 13:12:05 +0100
Message-ID: <CAMpxmJWMjae8vuNA7feLWp1aXte4a3_RTA+C1PoDBkx3EPpO0g@mail.gmail.com>
Subject: Re: [PATCH 2/2] drivers: platform: provide devm_platform_ioremap_resource_nocache()
To:     Yangtao Li <tiny.windzz@gmail.com>
Cc:     Jonathan Corbet <corbet@lwn.net>,
        Greg KH <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>, Stephen Boyd <sboyd@kernel.org>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
        Phil Edworthy <phil.edworthy@renesas.com>,
        suzuki.poulose@arm.com, saravanak@google.com,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        dan.j.williams@intel.com, Joe Perches <joe@perches.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>, mans@mansr.com,
        Thomas Gleixner <tglx@linutronix.de>, hdegoede@redhat.com,
        Andrew Morton <akpm@linux-foundation.org>,
        ulf.hansson@linaro.org, ztuowen@gmail.com,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        linux-doc <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

niedz., 29 gru 2019 o 11:43 Yangtao Li <tiny.windzz@gmail.com> napisa=C5=82=
(a):
>
> Provide a nocache variant of devm_platform_ioremap_resource().
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
>  .../driver-api/driver-model/devres.rst        |  1 +
>  drivers/base/platform.c                       | 19 +++++++++++++++++++
>  include/linux/platform_device.h               |  3 +++
>  3 files changed, 23 insertions(+)
>
> diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documenta=
tion/driver-api/driver-model/devres.rst
> index af1b1b9e3a17..3b79a3207490 100644
> --- a/Documentation/driver-api/driver-model/devres.rst
> +++ b/Documentation/driver-api/driver-model/devres.rst
> @@ -320,6 +320,7 @@ IOMAP
>    devm_ioremap_resource_nocache()
>    devm_ioremap_resource_wc()
>    devm_platform_ioremap_resource() : calls devm_ioremap_resource() for p=
latform device
> +  devm_platform_ioremap_resource_nocache()
>    devm_platform_ioremap_resource_wc()
>    devm_platform_ioremap_resource_byname()
>    devm_iounmap()
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index cf6b6b722e5c..80f420b9b4d7 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -79,6 +79,25 @@ void __iomem *devm_platform_ioremap_resource(struct pl=
atform_device *pdev,
>  }
>  EXPORT_SYMBOL_GPL(devm_platform_ioremap_resource);
>
> +/**
> + * devm_platform_ioremap_resource_nocache - nocache variant of
> + *                                         devm_platform_ioremap_resourc=
e()
> + *
> + * @pdev: platform device to use both for memory resource lookup as well=
 as
> + *        resource management
> + * @index: resource index
> + */
> +void __iomem *
> +devm_platform_ioremap_resource_nocache(struct platform_device *pdev,
> +                                      unsigned int index)
> +{
> +       struct resource *res;
> +
> +       res =3D platform_get_resource(pdev, IORESOURCE_MEM, index);
> +       return devm_ioremap_resource_nocache(&pdev->dev, res);
> +}
> +EXPORT_SYMBOL_GPL(devm_platform_ioremap_resource_nocache);
> +
>  /**
>   * devm_platform_ioremap_resource_wc - write-combined variant of
>   *                                     devm_platform_ioremap_resource()
> diff --git a/include/linux/platform_device.h b/include/linux/platform_dev=
ice.h
> index 276a03c24691..b803e670b1c5 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -58,6 +58,9 @@ extern void __iomem *
>  devm_platform_ioremap_resource(struct platform_device *pdev,
>                                unsigned int index);
>  extern void __iomem *
> +devm_platform_ioremap_resource_nocache(struct platform_device *pdev,
> +                                      unsigned int index);
> +extern void __iomem *
>  devm_platform_ioremap_resource_wc(struct platform_device *pdev,
>                                   unsigned int index);
>  extern void __iomem *
> --
> 2.17.1
>

Please see my response to patch 1/2.

Bart