Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 29 Dec 2019 15:00:05 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To:     Namjae Jeon <namjae.jeon@samsung.com>
Cc:     linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
        sj1557.seo@samsung.com, linkinjeon@gmail.com
Subject: Re: [PATCH v8 09/13] exfat: add misc operations
Message-ID: <20191229140005.qrffmjnmizstjkh4@pali>
References: <20191220062419.23516-1-namjae.jeon@samsung.com>
 <CGME20191220062737epcas1p3c0f9e408640148c9186b84efc6d6658b@epcas1p3.samsung.com>
 <20191220062419.23516-10-namjae.jeon@samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="o5ddwdsvztwdyzxl"
Content-Disposition: inline
In-Reply-To: <20191220062419.23516-10-namjae.jeon@samsung.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--o5ddwdsvztwdyzxl
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Friday 20 December 2019 01:24:15 Namjae Jeon wrote:
> This adds the implementation of misc operations for exfat.
>=20
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
> ---
>  fs/exfat/misc.c | 240 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 240 insertions(+)
>  create mode 100644 fs/exfat/misc.c
>=20
> diff --git a/fs/exfat/misc.c b/fs/exfat/misc.c
> new file mode 100644
> index 000000000000..2fa182cd4ff2
> --- /dev/null
> +++ b/fs/exfat/misc.c

=2E..

> +/* Convert linear UNIX date to a FAT time/date pair. */
> +void exfat_time_unix2fat(struct exfat_sb_info *sbi, struct timespec64 *t=
s,
> +		struct exfat_date_time *tp)
> +{
> +	time_t second =3D ts->tv_sec;
> +	time_t day, month, year;
> +	time_t ld; /* leap day */
> +
> +	if (!sbi->options.tz_utc)
> +		second -=3D sys_tz.tz_minuteswest * SECS_PER_MIN;
> +
> +	/* Jan 1 GMT 00:00:00 1980. But what about another time zone? */
> +	if (second < UNIX_SECS_1980) {
> +		tp->second  =3D 0;
> +		tp->minute  =3D 0;
> +		tp->hour =3D 0;
> +		tp->day  =3D 1;
> +		tp->month  =3D 1;
> +		tp->year =3D 0;
> +		return;
> +	}
> +#if (BITS_PER_LONG =3D=3D 64)
> +	if (second >=3D UNIX_SECS_2108) {
> +		tp->second  =3D 59;
> +		tp->minute  =3D 59;
> +		tp->hour =3D 23;
> +		tp->day  =3D 31;
> +		tp->month  =3D 12;
> +		tp->year =3D 127;
> +		return;
> +	}
> +#endif

Hello! Why is this code #if-ed? Kernel supports 64 bit long long
integers also for 32 bit platforms.

Function parameter struct timespec64 *ts is already 64 bit. so above
#if-code looks really suspicious.

> +
> +	day =3D second / SECS_PER_DAY - DAYS_DELTA_DECADE;
> +	year =3D day / 365;
> +
> +	MAKE_LEAP_YEAR(ld, year);
> +	if (year * 365 + ld > day)
> +		year--;
> +
> +	MAKE_LEAP_YEAR(ld, year);
> +	day -=3D year * 365 + ld;

--=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--o5ddwdsvztwdyzxl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCXgixYwAKCRCL8Mk9A+RD
UrL7AKCCZpXpghQmLjXT12GlDiQnZrtZqQCeOtO1ZAc8ycv+mwxPtum98ybnRT8=
=FbCv
-----END PGP SIGNATURE-----

--o5ddwdsvztwdyzxl--