Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 29 Dec 2019 15:15:50 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To:     Namjae Jeon <namjae.jeon@samsung.com>
Cc:     linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
        sj1557.seo@samsung.com, linkinjeon@gmail.com
Subject: Re: [PATCH v8 03/13] exfat: add inode operations
Message-ID: <20191229141550.w66jnp2ayvd4bkk3@pali>
References: <20191220062419.23516-1-namjae.jeon@samsung.com>
 <CGME20191220062733epcas1p1afd7af6ca2bfbde3d9a883f55f4f3b60@epcas1p1.samsung.com>
 <20191220062419.23516-4-namjae.jeon@samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="nfhy2aomfwhdigtr"
Content-Disposition: inline
In-Reply-To: <20191220062419.23516-4-namjae.jeon@samsung.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--nfhy2aomfwhdigtr
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Friday 20 December 2019 01:24:09 Namjae Jeon wrote:
> This adds the implementation of inode operations for exfat.
>=20
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
> ---
>  fs/exfat/inode.c |  694 ++++++++++++++++++++++
>  fs/exfat/namei.c | 1459 ++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 2153 insertions(+)
>  create mode 100644 fs/exfat/inode.c
>  create mode 100644 fs/exfat/namei.c

=2E..

> diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c
> new file mode 100644
> index 000000000000..1bda97b82ef4
> --- /dev/null
> +++ b/fs/exfat/namei.c

=2E..

> +
> +/*
> + * Name Resolution Functions :
> + * Zero if it was successful; otherwise nonzero.
> + */
> +static int __exfat_resolve_path(struct inode *inode, const unsigned char=
 *path,
> +		struct exfat_chain *p_dir, struct exfat_uni_name *p_uniname,
> +		int lookup)
> +{
> +	int namelen;
> +	int lossy =3D NLS_NAME_NO_LOSSY;
> +	struct super_block *sb =3D inode->i_sb;
> +	struct exfat_sb_info *sbi =3D EXFAT_SB(sb);
> +	struct exfat_inode_info *ei =3D EXFAT_I(inode);
> +
> +	/* DOT and DOTDOT are handled by VFS layer */
> +
> +	/* strip all trailing spaces */
> +	/* DO NOTHING : Is needed? */

Hello, this comment looks like a TODO item which should be fixed.

> +
> +	/* strip all trailing periods */
> +	namelen =3D __exfat_striptail_len(strlen(path), path);
> +	if (!namelen)
> +		return -ENOENT;
> +
> +	/* the limitation of linux? */

And this one too.

> +	if (strlen(path) > (MAX_NAME_LENGTH * MAX_CHARSET_SIZE))
> +		return -ENAMETOOLONG;
> +
> +	/*
> +	 * strip all leading spaces :
> +	 * "MS windows 7" supports leading spaces.
> +	 * So we should skip this preprocessing for compatibility.
> +	 */
> +
> +	/* file name conversion :
> +	 * If lookup case, we allow bad-name for compatibility.
> +	 */
> +	namelen =3D exfat_nls_vfsname_to_uni16s(sb, path, namelen, p_uniname,
> +			&lossy);
> +	if (namelen < 0)
> +		return namelen; /* return error value */
> +
> +	if ((lossy && !lookup) || !namelen)
> +		return -EINVAL;
> +
> +	exfat_chain_set(p_dir, ei->start_clu,
> +		EXFAT_B_TO_CLU(i_size_read(inode), sbi), ei->flags);
> +
> +	return 0;
> +}
> +

--=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--nfhy2aomfwhdigtr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCXgi1FAAKCRCL8Mk9A+RD
UtZbAJ9kvwSHrQAHJ7JZmR7C4bLPpG997QCfaxuwF41zC5bTAs1dH8LEqlm3zhQ=
=sQej
-----END PGP SIGNATURE-----

--nfhy2aomfwhdigtr--