Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13328379ybl; Sun, 29 Dec 2019 09:24:36 -0800 (PST) X-Google-Smtp-Source: APXvYqx3DgRF0r0mU1x3neaqTEFQ6vbl93KSjilOKuB6/0hUSvg7UErHg2onpXo0yMjMld6isMdC X-Received: by 2002:a05:6830:304c:: with SMTP id p12mr39219603otr.214.1577640276188; Sun, 29 Dec 2019 09:24:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577640276; cv=none; d=google.com; s=arc-20160816; b=FlA4W37QixzB/MtAx7HhgDz9AStqTyGS1vc+1xtQutIsj9oSNLRB5hIPbINb9N0HfO M+aUl4MJfLrDlA6AnEKRJrSfu6ZKWncPwZVG9j2a4R/2ek/xSqGnrDNu/q+fYPR0ldOm KltaIRDXx7r/KGYTF0YQsYNSwWOJJzCnsaWV/1Kz+JpVgGLyhzJ7Uo1SNLhecZ4g0QCX r/E261tdKnMTNzNi9PHUfU3IAXxR6DjXHVltYl50ZjH3O81p12t7f+Ax3VJpIKz/gBLm peulQRhvkpMGOheIUpM0e6PQFAbd8BMiB0Kn0GT9ETEzQGoWAy6LrUMd8f59zrw1t4U3 +oOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qMrSJeQSkY6tYShAm2TD3Bj4QuxQ5e6VgIKMNYgL2kA=; b=hNa1dRqKdbthS8oBUeIM0InxLs0ZzjROpPcWgI33NqryeahV/8KR5Ym1J9BJ6PSL55 jOecsA7om6nelKYkT4mnIUTjAw3SqZL8VlHGvJIPfQQfGuJt3dIM9cW4qPx/1blML88c cx4uiBL0qkR68JC2rMmUxTElgTYe8Vi1ZNIE7YdipM460/bwKwEaZMNKtxkSKAze3Ooq fhm4NDyZ5E7UoBUAQ56/GondkN9eX4Zm9AvMIjCAUMG69VUz/hrsykuJL/k4SBYI2L3z 1Vpq27iBJwMjK9QjK5SCnuDXBmEdr+W7io9Gd68s3EAtE1r/NP2osgGG1QtOgsOKtKne 3j9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AJn1w6UH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m26si21137491otn.307.2019.12.29.09.24.25; Sun, 29 Dec 2019 09:24:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AJn1w6UH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727515AbfL2RXU (ORCPT + 99 others); Sun, 29 Dec 2019 12:23:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:40614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727507AbfL2RXQ (ORCPT ); Sun, 29 Dec 2019 12:23:16 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D3C49207FF; Sun, 29 Dec 2019 17:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640195; bh=d0/54zHd7bFo7CaWOxGyfNacHyy66MG5DTVPdEA80z8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AJn1w6UH1+tj5XoFY4IP7ZmHg1YIGqbqaBxBeRqnbAxhSXX1U+nB2tXoX2i1yveDE rcJEM85W66dHlqv0PVdKtjPMEVFf6rxRXl5tORcF5l7Q/cmdpWTMKFkRt3biKeYmq7 Gi6d5KQL6gcPgJEIJcHXBs8W8hvYcG3QT4Mpf3vg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Veeraiyan Chidambaram , Eugeniu Rosca , Yoshihiro Shimoda , Sasha Levin Subject: [PATCH 4.14 040/161] usb: renesas_usbhs: add suspend event support in gadget mode Date: Sun, 29 Dec 2019 18:18:08 +0100 Message-Id: <20191229162411.724779098@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162355.500086350@linuxfoundation.org> References: <20191229162355.500086350@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Veeraiyan Chidambaram [ Upstream commit 39abcc84846bbc0538f13c190b6a9c7e36890cd2 ] When R-Car Gen3 USB 2.0 is in Gadget mode, if host is detached an interrupt will be generated and Suspended state bit is set in interrupt status register. Interrupt handler will call driver->suspend(composite_suspend) if suspended state bit is set. composite_suspend will call ffs_func_suspend which will post FUNCTIONFS_SUSPEND and will be consumed by user space application via /dev/ep0. To be able to detect host detach, extend the DVSQ_MASK to cover the Suspended bit of the DVSQ[2:0] bitfield from the Interrupt Status Register 0 (INTSTS0) register and perform appropriate action in the DVST interrupt handler (usbhsg_irq_dev_state). Without this commit, disconnection of the phone from R-Car-H3 ES2.0 Salvator-X CN9 port is not recognized and reverse role switch does not happen. If phone is connected again it does not enumerate. With this commit, disconnection will be recognized and reverse role switch will happen by a user space application. If phone is connected again it will enumerate properly and will become visible in the output of 'lsusb'. Signed-off-by: Veeraiyan Chidambaram Signed-off-by: Eugeniu Rosca Reviewed-by: Yoshihiro Shimoda Tested-by: Yoshihiro Shimoda Link: https://lore.kernel.org/r/1568207756-22325-3-git-send-email-external.veeraiyan.c@de.adit-jv.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/renesas_usbhs/common.h | 3 ++- drivers/usb/renesas_usbhs/mod_gadget.c | 12 +++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/usb/renesas_usbhs/common.h b/drivers/usb/renesas_usbhs/common.h index b8620aa6b72e..8424c165f732 100644 --- a/drivers/usb/renesas_usbhs/common.h +++ b/drivers/usb/renesas_usbhs/common.h @@ -163,11 +163,12 @@ struct usbhs_priv; #define VBSTS (1 << 7) /* VBUS_0 and VBUSIN_0 Input Status */ #define VALID (1 << 3) /* USB Request Receive */ -#define DVSQ_MASK (0x3 << 4) /* Device State */ +#define DVSQ_MASK (0x7 << 4) /* Device State */ #define POWER_STATE (0 << 4) #define DEFAULT_STATE (1 << 4) #define ADDRESS_STATE (2 << 4) #define CONFIGURATION_STATE (3 << 4) +#define SUSPENDED_STATE (4 << 4) #define CTSQ_MASK (0x7) /* Control Transfer Stage */ #define IDLE_SETUP_STAGE 0 /* Idle stage or setup stage */ diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index 0dedb0d91dcc..b27f2135b66d 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -465,12 +465,18 @@ static int usbhsg_irq_dev_state(struct usbhs_priv *priv, { struct usbhsg_gpriv *gpriv = usbhsg_priv_to_gpriv(priv); struct device *dev = usbhsg_gpriv_to_dev(gpriv); + int state = usbhs_status_get_device_state(irq_state); gpriv->gadget.speed = usbhs_bus_get_speed(priv); - dev_dbg(dev, "state = %x : speed : %d\n", - usbhs_status_get_device_state(irq_state), - gpriv->gadget.speed); + dev_dbg(dev, "state = %x : speed : %d\n", state, gpriv->gadget.speed); + + if (gpriv->gadget.speed != USB_SPEED_UNKNOWN && + (state & SUSPENDED_STATE)) { + if (gpriv->driver && gpriv->driver->suspend) + gpriv->driver->suspend(&gpriv->gadget); + usb_gadget_set_state(&gpriv->gadget, USB_STATE_SUSPENDED); + } return 0; } -- 2.20.1