Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13333287ybl; Sun, 29 Dec 2019 09:30:48 -0800 (PST) X-Google-Smtp-Source: APXvYqyKXJlqeyTAr8ieU4xWYmw/d8hIsfVvOf+Ci33GSzUb0cY78Oe/FZpbhpJK2SnrR74yCgLH X-Received: by 2002:a9d:7f11:: with SMTP id j17mr72303258otq.281.1577640648580; Sun, 29 Dec 2019 09:30:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577640648; cv=none; d=google.com; s=arc-20160816; b=sXBZAky+IxZTUr+ILGgYxqvJo5wkCTGEU/d6FhM8psz0gU9qSEj+VMfq/j2lWdzFfN yWcXPfecBPDg/bxxUTTiUxGKQfJxLvMlF0WYb5YXIcdgToz1+wKy22HkSqsjnpDaTUqN eAeO4Nbj8ZvHsSzZM0KaBsxRThOf0jq7qsqkUry9CEnbM92IQlC1YXh1jqDbt2+33Qsc vzq9Y//4r9EkQ1MG5/+dYCxfoD/dwqRIys5dboSVLbgH/+XaHwSA0l8NS+VcOfRV4wtN rTyh7FUrlDS0DmBtlyUhUqttmG/ManoMGgzrg1AbAy0WVkotC6cjyGe3ciYZrf1nEeWh WCPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0D4Q/wP2DvbVl0dpPfjabj6FXwTQlNtPsiEykO4U3ew=; b=BznLPmuNHTiED/9vJkE9eB6q6XnLA6nkeNpFPQJyb3txjc6XiHGRLICRwl+duduQG9 Sc394R7lUvO89cacQgiypVINzSPj6FGVuNrFW8R5Oq0J7bq96L5aTaBQ4M3GRuXyj6uS nEhf4M8wqDz8x4cM5qk5haCEGaOcLT/3wlVDw9EOQVRY/tWkViwdXum2eFD+6bfvzhUX v51LlTE8TBudbRLDntHzLZ/hafASFdMqMIeiYb+JomzBVim6pizKanIgQ1UNW2dRfpOR wlnFMI1NDje7ixsYQxBUYPDccPakuyoORCz2wTmqwP3h7BDAgmIxzGww6uoMPrZq/fos +LEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pIgeyKdh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e63si20028858ote.166.2019.12.29.09.30.38; Sun, 29 Dec 2019 09:30:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pIgeyKdh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728793AbfL2R3d (ORCPT + 99 others); Sun, 29 Dec 2019 12:29:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:54144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728778AbfL2R33 (ORCPT ); Sun, 29 Dec 2019 12:29:29 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D097207FD; Sun, 29 Dec 2019 17:29:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640568; bh=prkrhnJRoSbtS7JX9q8fq7A4FByQwa0ZP1hOz0/cf8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pIgeyKdhmN2kWorL2MaZiaSAH9T7SE/kUZtToIu479RK1XwLA4y/oCB3RKdTBbu3J vYNmMdKFuFDAhFAWmZvCX/xhwLcKpm9go3Apz2J0JQksgM4567gfL5IbpiTfPC36d9 Qra/bjuJ5z6QzFAL6V//gmO/msnkBKaGFYRrhLcg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Cristian Birsan , "David S. Miller" Subject: [PATCH 4.19 009/219] net: usb: lan78xx: Fix suspend/resume PHY register access error Date: Sun, 29 Dec 2019 18:16:51 +0100 Message-Id: <20191229162510.345406284@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162508.458551679@linuxfoundation.org> References: <20191229162508.458551679@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cristian Birsan [ Upstream commit 20032b63586ac6c28c936dff696981159913a13f ] Lan78xx driver accesses the PHY registers through MDIO bus over USB connection. When performing a suspend/resume, the PHY registers can be accessed before the USB connection is resumed. This will generate an error and will prevent the device to resume correctly. This patch adds the dependency between the MDIO bus and USB device to allow correct handling of suspend/resume. Fixes: ce85e13ad6ef ("lan78xx: Update to use phylib instead of mii_if_info.") Signed-off-by: Cristian Birsan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/lan78xx.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1823,6 +1823,7 @@ static int lan78xx_mdio_init(struct lan7 dev->mdiobus->read = lan78xx_mdiobus_read; dev->mdiobus->write = lan78xx_mdiobus_write; dev->mdiobus->name = "lan78xx-mdiobus"; + dev->mdiobus->parent = &dev->udev->dev; snprintf(dev->mdiobus->id, MII_BUS_ID_SIZE, "usb-%03d:%03d", dev->udev->bus->busnum, dev->udev->devnum);