Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13334434ybl; Sun, 29 Dec 2019 09:31:59 -0800 (PST) X-Google-Smtp-Source: APXvYqxw2z5SeNo7YxLVLhmyj+p636NECeUoe5WegVc8BliflLiVy/+LmXkXBM3ufgyUGw7Rft4s X-Received: by 2002:a05:6830:3014:: with SMTP id a20mr44284421otn.350.1577640719240; Sun, 29 Dec 2019 09:31:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577640719; cv=none; d=google.com; s=arc-20160816; b=bdZzC1x8ABgkEFDRkLoLBM7aEgyXu4QVrDIcSOP13H52th/qCgepk/BpcExDQPVuVg 9LxLAigA3WbF9cjoX+aGmk4ijhSUgfvzA6jvKZbLzDnA/f5lrRg6GKH53t/1pwnRfhFp S0X7eVCCxj5kCAjT4qrpxkfi+YbQmUXxJ/iJx4ctTlGGwKA1/laEpAl5cdGTIdBFu0Pl oUMESEC9iM2ZgoBA9RpA9LcXs9QBKVMiwlX81gxQ9vo2gOm8LKKvxKgSCG8oZKD1Dfpi PbYyA7K8oN7iZbfFH880/QjZtnCZFfRIYN6hSx1MB6+DOjXygZ55PWsEua+Z+uWlF+MQ Z8rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=b1lB0wMAGOVCnUxul7+oi3EAt/Nyma3wAqB8bS/o+U8=; b=g4flK8GTWK4Mv78IPlZLTLcNhDkLCbxPcGfhUzEFslbHltRYyb2O6ROifY/WWBYUke HYXLgpDKm+5TefkivWA1KTjXmKJ9G1SENaxRrMVWbgI3DJxwKw2Dt78CFebj4lGUJYx9 BCpPMcuqfN2pDhfJctfDVCcoIIyAAQX7FrNAL2lkyi3SPA/eypAaVmVoCVhpIGjww+OI 68Z/Xzz+eFaCLrLOy8uEZQKxSaaa2t2FhHqWvEWMmgjrrWjOy9/0op6z0KQJOXaW2gKX J7Hftq8FOhinyVSiHutxDQKwRQi40id07bmteVzofzGugUu4A77iQEYOrNqy86Gn6WSj +QBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TzX9LG70; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a64si20335718oif.256.2019.12.29.09.31.47; Sun, 29 Dec 2019 09:31:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TzX9LG70; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729021AbfL2Ran (ORCPT + 99 others); Sun, 29 Dec 2019 12:30:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:57022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728740AbfL2Ral (ORCPT ); Sun, 29 Dec 2019 12:30:41 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC7DC208E4; Sun, 29 Dec 2019 17:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640640; bh=F+RVtGEVmdod50DfTH1VyNi8CRxmTqjjFgd97kF6+zU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TzX9LG70BOjc+bcLzvQFQ+LU0OfSxHA/ahCXqiytZeYDR/H5o1iRjLmlzhxwHaLOf TD0RsPylpXwXuoqkxom5jQoxRgiu7fEctyHPlOks1tD+aVxl3YtrwC+2MAJTVSQMsz ga66bgOpuLKxkYXApWqR6rXV3peLt/ZeNsd1aGLw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Leo Yan , Alexander Shishkin , Jiri Olsa , Mark Rutland , Namhyung Kim , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 4.19 077/219] perf test: Report failure for mmap events Date: Sun, 29 Dec 2019 18:17:59 +0100 Message-Id: <20191229162517.555116819@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162508.458551679@linuxfoundation.org> References: <20191229162508.458551679@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Leo Yan [ Upstream commit 6add129c5d9210ada25217abc130df0b7096ee02 ] When fail to mmap events in task exit case, it misses to set 'err' to -1; thus the testing will not report failure for it. This patch sets 'err' to -1 when fails to mmap events, thus Perf tool can report correct result. Fixes: d723a55096b8 ("perf test: Add test case for checking number of EXIT events") Signed-off-by: Leo Yan Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Link: http://lore.kernel.org/lkml/20191011091942.29841-1-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/tests/task-exit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c index e92fa6029ac7..788b0805d2f1 100644 --- a/tools/perf/tests/task-exit.c +++ b/tools/perf/tests/task-exit.c @@ -105,6 +105,7 @@ int test__task_exit(struct test *test __maybe_unused, int subtest __maybe_unused if (perf_evlist__mmap(evlist, 128) < 0) { pr_debug("failed to mmap events: %d (%s)\n", errno, str_error_r(errno, sbuf, sizeof(sbuf))); + err = -1; goto out_delete_evlist; } -- 2.20.1