Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13335811ybl; Sun, 29 Dec 2019 09:33:42 -0800 (PST) X-Google-Smtp-Source: APXvYqzzJpMyCrxoJ51zjDhrzJUABSwEgBVtjCGx4wnbK9ljwbzGl7eQEQkMCaZCP+xX4OxpHJZ0 X-Received: by 2002:a9d:600e:: with SMTP id h14mr67547410otj.113.1577640822336; Sun, 29 Dec 2019 09:33:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577640822; cv=none; d=google.com; s=arc-20160816; b=Ze9qo5o0dJqvB3KU2lIYqh6rRaHz2vPhWYJYPeOxOHG8Zigbl0bWBird2jN6a9iyF9 YR2Lg4lf4uXYMk0glenMegEonDWaYdIEJjCK38lTMsCLq1i6rANkKqyn+7yUgpuVM09Y U/86Rc0cqzsgJpu3ucJFDpuYA2rx/YvGHeKrnWxewEtshfygIJEeLDltRVhfajWAaSmx F5iK71P7ohXqIAN5dul6C4pip3rzmZ/MLu9mOZGWovfp0sErGTNfWZxhp/9fxhN/CHpp GxhVVvz8nLwXhKBGspZvF7f9JMzQCqN0YdrZuOlYeM3UkbKs3x6CM27HupVlee/G9UaB Pb3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PH0vM+k21gVQJaL/NOAS+v6B0JiA5yMT74mKGGKb5JI=; b=TVHLRt74+I5TwSYPTTTRaHoE+9U3Rmf+XBfFKZb2wAkVZ7WKZMXTUl0DwqEc5MnKSX LK6Y9rmwDqZRCpw3i5XfzbHegTPmx/bYbIobUxbOcapqb0F4t/04Ut7QTfo08GQjAqMM XbdvJpPFwWvRNkvmbyHRU4YclM+kmgdqvaK4+ZeAWUQR4FVZExNhzfGzhKbdqKVRKKa4 islZVy61VGEIQ6rps/9RxQufriBrKCfA+5m34p5K6F8pIyyb6Z0Yil2zefOv7XgZ6oMp BlVm2b20GbKX495YbSwrDUIumQTpNIypDveuu6Y8AV6BHSaCpukodS+viOnzcI8sAOI+ emqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ffACs2+S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k84si18261827oib.46.2019.12.29.09.33.30; Sun, 29 Dec 2019 09:33:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ffACs2+S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729310AbfL2RcZ (ORCPT + 99 others); Sun, 29 Dec 2019 12:32:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:60924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728844AbfL2RcX (ORCPT ); Sun, 29 Dec 2019 12:32:23 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97E4D20409; Sun, 29 Dec 2019 17:32:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640743; bh=5y2IxP1j9aBSlpmb44OlH+IM1A2ULC4taBIZAgZca7s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ffACs2+SOYsxLg1DKAXSZz4g2kT0Aqtt1/zWBUdFO/FhqFT+zTgpGSUJUvlCgV/45 Ejgt08/ZPG7IDnIjQcSG0gqQCX0Bm1HhwOtX5wtDyNRffHcGLNM2E0Jb8yJLDNWUOp BKmdCu3wfw8nheOEVzqTJc7ugN701L23HWsEWJKE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Manish Chopra , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 119/219] bnx2x: Fix PF-VF communication over multi-cos queues. Date: Sun, 29 Dec 2019 18:18:41 +0100 Message-Id: <20191229162526.551135007@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162508.458551679@linuxfoundation.org> References: <20191229162508.458551679@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manish Chopra [ Upstream commit dc5a3d79c345871439ffe72550b604fcde9770e1 ] PF driver doesn't enable tx-switching for all cos queues/clients, which causes packets drop from PF to VF. Fix this by enabling tx-switching on all cos queues/clients. Signed-off-by: Manish Chopra Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- .../net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 62da46537734..ab60f4f9cc24 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -2394,15 +2394,21 @@ static int bnx2x_set_pf_tx_switching(struct bnx2x *bp, bool enable) /* send the ramrod on all the queues of the PF */ for_each_eth_queue(bp, i) { struct bnx2x_fastpath *fp = &bp->fp[i]; + int tx_idx; /* Set the appropriate Queue object */ q_params.q_obj = &bnx2x_sp_obj(bp, fp).q_obj; - /* Update the Queue state */ - rc = bnx2x_queue_state_change(bp, &q_params); - if (rc) { - BNX2X_ERR("Failed to configure Tx switching\n"); - return rc; + for (tx_idx = FIRST_TX_COS_INDEX; + tx_idx < fp->max_cos; tx_idx++) { + q_params.params.update.cid_index = tx_idx; + + /* Update the Queue state */ + rc = bnx2x_queue_state_change(bp, &q_params); + if (rc) { + BNX2X_ERR("Failed to configure Tx switching\n"); + return rc; + } } } -- 2.20.1