Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13338288ybl; Sun, 29 Dec 2019 09:36:52 -0800 (PST) X-Google-Smtp-Source: APXvYqwTiX003NmXJS0ebll/ZRI1j8AUwk4IBjMa0QJoxnpnVZVjVQYoO6mpPNgwxUA2MPX8OyVp X-Received: by 2002:a05:6830:1487:: with SMTP id s7mr47211927otq.269.1577641012836; Sun, 29 Dec 2019 09:36:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577641012; cv=none; d=google.com; s=arc-20160816; b=jQRcOip1HV2A16YSqUOMG0bCkMMuIz+9bspljOvjIA4BYX7oSMtzNDVpuTTw5x6zv0 iYKuvpoOfD0ErTR8d3TBJ2PgGBzkPoXOyZxrXM1rznl8RkWo2aTT0xs4AJvHm6Jn35qM 5ym5wFQU2d3XXdLbU8LGyM7v89WZ0eHzfY0s8YgBiBcy4/CF/XjMas4ienBPRQbon4xk ogOOlJwpqHX1OtuBe74rYiDQa2dcG6Ol/wrDvfy4YncA40nTsUddDhvQTU+BcIQ1TXQw vj1ogxb5w3PmFCySosKyAQSjqwyJJMoPl9ho+qURdZBHWWDfkmA4liDELwF9tUaKcTo3 mRWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/IFdX2casB4pV2m8ncfu/yCyFXKHdA1Wx42gZSJl/yY=; b=f4xbSrCruCv4r2SvxjrRRTR20av0oO/kjgxCFevHC7w2KcZUsBghgy3Afok4CDS+eV egYt5+u+XjiwanoBD2XXZ+6ojfmdRzt/jY9s70f/7O0kbgNCZe5siEc8ciVOSyJuU8b4 IHWZypB/Mgki4GxgP6rJg3CzZz4ocT9CAg6croHm+Ux8vMGb1NulQ8Hs829U4/W6xZ6n 13QNvSbWid9ps/vouDj6v5HBzb/T07wKyiJfIs4GzEaFvKJ5aJRjkFhXx2sOcpnkrYVP 4GcMV5X/Bb5B/8POz3ly/momuBPiyg5ojxPgcCXjJjBIvprGoGXdm0A5DFV3UJEL48jg Fjaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aobpxLEi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x11si4011377oic.185.2019.12.29.09.36.42; Sun, 29 Dec 2019 09:36:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aobpxLEi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729910AbfL2Rfk (ORCPT + 99 others); Sun, 29 Dec 2019 12:35:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:40148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729890AbfL2Rfh (ORCPT ); Sun, 29 Dec 2019 12:35:37 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 67914207FF; Sun, 29 Dec 2019 17:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640936; bh=ssymBFOqeRPxQ7sSX7Zmtt2Y0cloGLCzXEyuNa3o5cU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aobpxLEirNiji0Sv1KSrc5lN+dNOFO9CtroJH8AS/Yc0uZbB3MAXe11ZcvyPFd3Nh eXCfTGukeMMv5qFaNhcr2M0Tpf56q0torcVrELSBNtcGAsWG7868/k2IyILiyaO9y0 xlwi3ajUaNkQJNGSnb7AuIV+HS2CmPISbbUPBeWE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Charles Keepax , Mark Brown , Sasha Levin Subject: [PATCH 4.19 173/219] ASoC: wm5100: add missed pm_runtime_disable Date: Sun, 29 Dec 2019 18:19:35 +0100 Message-Id: <20191229162535.096646432@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162508.458551679@linuxfoundation.org> References: <20191229162508.458551679@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit b1176bbb70866f24099cd2720283c7219fb4a81c ] The driver forgets to call pm_runtime_disable in remove and probe failure. Add the calls to fix it. Signed-off-by: Chuhong Yuan Acked-by: Charles Keepax Link: https://lore.kernel.org/r/20191118073707.28298-1-hslester96@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wm5100.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c index ba89d9d711f7..b793701aafcd 100644 --- a/sound/soc/codecs/wm5100.c +++ b/sound/soc/codecs/wm5100.c @@ -2620,6 +2620,7 @@ static int wm5100_i2c_probe(struct i2c_client *i2c, return ret; err_reset: + pm_runtime_disable(&i2c->dev); if (i2c->irq) free_irq(i2c->irq, wm5100); wm5100_free_gpio(i2c); @@ -2643,6 +2644,7 @@ static int wm5100_i2c_remove(struct i2c_client *i2c) { struct wm5100_priv *wm5100 = i2c_get_clientdata(i2c); + pm_runtime_disable(&i2c->dev); if (i2c->irq) free_irq(i2c->irq, wm5100); wm5100_free_gpio(i2c); -- 2.20.1