Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13338734ybl; Sun, 29 Dec 2019 09:37:23 -0800 (PST) X-Google-Smtp-Source: APXvYqxWrtTPFF8BLXn74oNu7YJZl7MwDntL1vJP2/HVx5mbWtEVF4jJPtdULRe/VqTq+qso5E2T X-Received: by 2002:a9d:53c4:: with SMTP id i4mr58825165oth.48.1577641043258; Sun, 29 Dec 2019 09:37:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577641043; cv=none; d=google.com; s=arc-20160816; b=wVybc3HaNRccUYClnYuUBmk/XFuGPZomROmNAmm0d1d8y40FDL5kesx4aulj1waYG/ jxyS9zRaDzc9eOR0xp2eFD8MJQuw2HF7kIA0utA5rRnO5as/ctVeGYmCVgw5bB4SYot+ mlX8WRL/2TQ53bxI5+1u0xyzw4pvE5bDwFiY8GLQ13Doik1aofRzEjNnyBa6ACGp2BUA K43gP2mjOafNJOqdm6OzrX1b7OBDb3XHngSOoIr3XoBGaNcwsKHnQdoJeybujXyzCh8p Tucr2OYySeilmcP40aA0hhDHWtPe+PSg/uZH+aBQRDP8jR+E9aB0hcSozDbne560TLEw W2Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IzMbza48g5wKlKyOAHJqblOFS9drXicWlYlTZ+yKeMo=; b=zJtgd9+wK0xXmwQeTcQH6GnN0d2VFOVKaelqKfI69N0nN5+uyOESKv0nZP+5KEu6cO wfYalIdkHm2rK0/Nt/UtQ1zXAjRZMMfsjdW3QIJscXIqyZa7+N2cKlxjM41pdGU6TO4V MOrIYQY6hxoYUA6V8inGQSclMzbRqMo43sZ/xiv3DCdp9+fSu7osnBFKMYUGnb5inFAn bhGSRAfWS01wTZnODRJO5YUOo9qRTfgaRaMC74SwWDYJDZbgbKoeQZAd9tmS07K2Ipce C7lYsanyMKnTcd2FgV7pLE8m+0wAnUL/GaDPxYCqp14bmi+noaZ5JS9oISDdhHqkRqYC KHbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MWan0OdV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l19si19271143oii.54.2019.12.29.09.37.12; Sun, 29 Dec 2019 09:37:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MWan0OdV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729821AbfL2RfN (ORCPT + 99 others); Sun, 29 Dec 2019 12:35:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:39302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729808AbfL2RfK (ORCPT ); Sun, 29 Dec 2019 12:35:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8EB0121D7E; Sun, 29 Dec 2019 17:35:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640910; bh=8zHvYP0Gzde2DetqxjP/+n4pV0eXIBIfVJDS6jyzJ5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MWan0OdVx0qNhd0CeF/2KIyTbVGeyoQLmUWhL7IHhB5rEG8IHRSE8cp9ItImKYxNo qGe9S+8TMMLicemsO6fWuv68zyYbh0lyDJWziNycp0CeGiimSJjjDt1ZxztB2HrOaV 3RvbRaCvwj7IifCQZX79BZ8MfrMLcLIwXnKAHa3U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Mark Brown , Sasha Levin Subject: [PATCH 4.19 172/219] spi: st-ssc4: add missed pm_runtime_disable Date: Sun, 29 Dec 2019 18:19:34 +0100 Message-Id: <20191229162534.823082996@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162508.458551679@linuxfoundation.org> References: <20191229162508.458551679@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit cd050abeba2a95fe5374eec28ad2244617bcbab6 ] The driver forgets to call pm_runtime_disable in probe failure and remove. Add the missed calls to fix it. Signed-off-by: Chuhong Yuan Link: https://lore.kernel.org/r/20191118024848.21645-1-hslester96@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-st-ssc4.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-st-ssc4.c b/drivers/spi/spi-st-ssc4.c index a4e43fc19ece..5df01ffdef46 100644 --- a/drivers/spi/spi-st-ssc4.c +++ b/drivers/spi/spi-st-ssc4.c @@ -385,6 +385,7 @@ static int spi_st_probe(struct platform_device *pdev) return 0; clk_disable: + pm_runtime_disable(&pdev->dev); clk_disable_unprepare(spi_st->clk); put_master: spi_master_put(master); @@ -396,6 +397,8 @@ static int spi_st_remove(struct platform_device *pdev) struct spi_master *master = platform_get_drvdata(pdev); struct spi_st *spi_st = spi_master_get_devdata(master); + pm_runtime_disable(&pdev->dev); + clk_disable_unprepare(spi_st->clk); pinctrl_pm_select_sleep_state(&pdev->dev); -- 2.20.1