Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13369264ybl; Sun, 29 Dec 2019 10:14:55 -0800 (PST) X-Google-Smtp-Source: APXvYqzIxCGvsyOkxO/nImxF9zzaGHPhXN8TzgqRKkC7mu0owVUCYxiw2F5CvwDlt/gxlZ6Ice92 X-Received: by 2002:a9d:6a41:: with SMTP id h1mr36413107otn.279.1577643295746; Sun, 29 Dec 2019 10:14:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577643295; cv=none; d=google.com; s=arc-20160816; b=Sw7RSoXLjM3EArp43sXgHyN6PhxwcH8fEf2P1KiheuitjzbABMy8j9YIzeglBGDsKx x3EFjtPj6mb9iCo8M3PK3CX+AzrXM+MJejG8A31wLG9pIw8z+wrd33KVn/Nh3+O2zLY3 9XryPtRaSPt5iL3IlQfuDEBAGLBjazwt2joDsgcPPBY9CsBMsxfZqfvFaTIpg/7THwhw m8e0LsvxiESOe0bo0BI1i7InQPr9SKddCddtWbIGhfpDkNxwAAn1E4iU8j1n/LoyuS28 HbEDAgs/zkNTak9Qcy7zojA5HdKKaHPhPPxk++AsDxatGoA/2mLAzAeWnbypi82tZ2qW dsOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=O78bVX/vdRvouW5DnZLhc7s8ZS9OvqJOpM1Bi6vjtgU=; b=UNkVWrVLEK1EbI52M2xXDzHCrhx6f9DiE3z+5iSyYSS4hVzIUAl9BexJaCw7bDrcfA xJPCn3cpwxbmkBsCCGLZ88qM0AFWhZnJFrRNn+8z7RFOhqZIgQ3WTGUruXVSGuQNFKd+ b7ZJChuNL4XyUiQhLtm2DySb7mpUtjszpI51GlfOKVzCooLMPDwQ4TqylNZrr788UD3N Ihe5KyHp/FhYUq9AN3/2Y31O19Jtjgd3o+5X+a+Bd8oD+2jyLpPKYCrE8Vi5MKZiv8AM Gqk/w6ogvvEXwtWki+t8m3Nk15hBz8sb+psvI6dRPZppamwiO9btbseMAQ7cd7TvszkQ runQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Eig6ZBNe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d17si18862917oij.136.2019.12.29.10.14.43; Sun, 29 Dec 2019 10:14:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Eig6ZBNe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731087AbfL2SNm (ORCPT + 99 others); Sun, 29 Dec 2019 13:13:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:50624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728496AbfL2R1x (ORCPT ); Sun, 29 Dec 2019 12:27:53 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9984320722; Sun, 29 Dec 2019 17:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640473; bh=3LB8rqRiyIvwRRLvI8gR+OWS2XUtX3mgWIjjIKtzew8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Eig6ZBNe2Hfqg2zuyE4PPfPQzLbOI3+NH7wn3FJq9lTFRsY0QWxYUyKLgdIIpr6j7 BXEBw8tUfNjRmMprMWHqaWj26VAshzSUSE6iJIIiGQ5rErCZZ0HQnk8koNGh01EJWs ThH+hv61iQES3fw8oYC++1GPgV6NVLpuLz7R4bUA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Manish Chopra , Ariel Elior , "David S. Miller" Subject: [PATCH 4.19 011/219] qede: Fix multicast mac configuration Date: Sun, 29 Dec 2019 18:16:53 +0100 Message-Id: <20191229162510.736284506@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162508.458551679@linuxfoundation.org> References: <20191229162508.458551679@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manish Chopra [ Upstream commit 0af67e49b018e7280a4227bfe7b6005bc9d3e442 ] Driver doesn't accommodate the configuration for max number of multicast mac addresses, in such particular case it leaves the device with improper/invalid multicast configuration state, causing connectivity issues (in lacp bonding like scenarios). Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qlogic/qede/qede_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/qlogic/qede/qede_filter.c +++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c @@ -1230,7 +1230,7 @@ qede_configure_mcast_filtering(struct ne netif_addr_lock_bh(ndev); mc_count = netdev_mc_count(ndev); - if (mc_count < 64) { + if (mc_count <= 64) { netdev_for_each_mc_addr(ha, ndev) { ether_addr_copy(temp, ha->addr); temp += ETH_ALEN;