Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13372873ybl; Sun, 29 Dec 2019 10:19:19 -0800 (PST) X-Google-Smtp-Source: APXvYqygEbwdtE9QobXCKomyaysco7QsGuucWmqMZOa5ICXYSJjWk0R/mg+Ywc5hlogRxL2EA7AM X-Received: by 2002:a9d:798e:: with SMTP id h14mr67646554otm.257.1577643559610; Sun, 29 Dec 2019 10:19:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577643559; cv=none; d=google.com; s=arc-20160816; b=jBsF9rL6aZ2JceEDNG10+w6RsXljKCnTjaKUAmv22MpyqB9A36K/t2RajAgGNzT/eo BlUrRO4ITpxKkOjq76flg3PdRQpdGONJX5Gwreqdmf6fgsR1Nb4JziUYsxEMSVUZES+N CWDp74tZtPSRQQS1suEBp1ZjJBBVG/2hdy5Wd8UU1NlxUY93a0a+iT78sIFvdh8mTPvS 8F4ZOdElWXLAiBc/QVk1lneZPQJ0ofPTaWh6E79T2TeMRILNuPalxdKtoE8TdehO71Jw 630zatAl0lenyPH9KcPbJSvGcdmVCOukMjHUGQwuL8bQepOrzWLPQwqfLAl8mWkK5IqN fa+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Pcec+Co7iyagba9ElROmLNTWuTvMMmno/fAl/anPS8s=; b=UiafOS/CYUHpY7WTPzjaSc2kvMp5vam4QRhY41FZpEiJuWMWPe9X+n8cxccsUommCb 4CQ17VUqRFM8zXzFNflLpxXiSbKXXW/cL+b0Y34elYM6tMjsXmXOPWAq/dJwo8beaBou fOm0JMNWNodt3gLlRklB0uEQZEIxCewIBIc/evUQUQu4sbMpBFWdArArv02sSJyXtW3q WZgcJATRaMi+IwHBx/6zQdywse4gSsQ5hC8+xPYT4RTpxU+Mh/ybZBqPzjEFxIJxWbO/ ShhbgwG/zO51ZFtJjOrmwCcf2uAfIHXAHDnAQ6PwYrkqhiMYq+HvMnP54+Y7yJix/4Jy 9oSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EjPtv2jl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s128si20122847oig.204.2019.12.29.10.19.08; Sun, 29 Dec 2019 10:19:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EjPtv2jl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727130AbfL2RVz (ORCPT + 99 others); Sun, 29 Dec 2019 12:21:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:37598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727101AbfL2RVx (ORCPT ); Sun, 29 Dec 2019 12:21:53 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4AC78208E4; Sun, 29 Dec 2019 17:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640112; bh=nMaQmfACss/jy3HnBrRn9mpVLBHDdBvmtGOMhDk4xhA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EjPtv2jle7XX82jTHdS14nBTb+XZueL5+AYTPz3sNSpxNyyWSoH9Ldx857ZAvAjID Tkpe6W0k5XOIosPcXgDN1Pw+OsAocpdID5OAbQfI2pBSbmZMe/9jm++7hzitpeQ5SZ 8SWqJaYL62n3JBQq9TVl8CNP+OW6Bqix78+p82tk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lukasz Majewski , Mark Brown , kbuild test robot , Sasha Levin Subject: [PATCH 4.14 023/161] spi: Add call to spi_slave_abort() function when spidev driver is released Date: Sun, 29 Dec 2019 18:17:51 +0100 Message-Id: <20191229162405.265879446@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162355.500086350@linuxfoundation.org> References: <20191229162355.500086350@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lukasz Majewski [ Upstream commit 9f918a728cf86b2757b6a7025e1f46824bfe3155 ] This change is necessary for spidev devices (e.g. /dev/spidev3.0) working in the slave mode (like NXP's dspi driver for Vybrid SoC). When SPI HW works in this mode - the master is responsible for providing CS and CLK signals. However, when some fault happens - like for example distortion on SPI lines - the SPI Linux driver needs a chance to recover from this abnormal situation and prepare itself for next (correct) transmission. This change doesn't pose any threat on drivers working in master mode as spi_slave_abort() function checks if SPI slave mode is supported. Signed-off-by: Lukasz Majewski Link: https://lore.kernel.org/r/20190924110547.14770-2-lukma@denx.de Signed-off-by: Mark Brown Reported-by: kbuild test robot Link: https://lore.kernel.org/r/20190925091143.15468-2-lukma@denx.de Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spidev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index c5fe08bc34a0..028725573e63 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -634,6 +634,9 @@ static int spidev_release(struct inode *inode, struct file *filp) if (dofree) kfree(spidev); } +#ifdef CONFIG_SPI_SLAVE + spi_slave_abort(spidev->spi); +#endif mutex_unlock(&device_list_lock); return 0; -- 2.20.1