Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13384267ybl; Sun, 29 Dec 2019 10:35:30 -0800 (PST) X-Google-Smtp-Source: APXvYqwTBLJPGJhZAeyeYcfJbGBi7ZZWoD/XbEiyIfSvAxk5LVAG8tbj978OL6pbdHCptrrEKGA0 X-Received: by 2002:a05:6830:1515:: with SMTP id k21mr54034240otp.177.1577644529955; Sun, 29 Dec 2019 10:35:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577644529; cv=none; d=google.com; s=arc-20160816; b=ltxoOChBbSGGco+q92PNrPoeUUiCjEiPJujljH/JHXEjjVRMyx3ZDHiOmDP2OoLBiZ 0w1Vm5G7I6fxWMBbLdo7H0+gR0Ia3Hv5nYIL/8BoeNJliucO7IE5veURUhDwxqGeYPdU 4Bq44ukOh+YLJKHipQTx61HPBjghCNAjCnwvOCDJHbODpYn44LLNAjHrTrfaOUW/I675 ZibJHQlWSJ6TLWBAps5vPScGvHzU/qqhHQ4IVmBaJC1EPNVIpYmoy0+LBOmh+mIVSuoe aZx6yXyu7clFs7wegRK6eypf8ii53NMtZ47bn52IhGd3UjkYaYG9HpvGzIvODer9T+lq UoLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=y0ZpxfrNlH8ZgooQAa3lpfyhBQKWEd1IcZJ7c1FbGAI=; b=ZvyAp8eaas6jlmeJsszlUrFTHYXv/fC4ySbVXrcQFrzZ739R4fQR270B0EI0db2xo9 2+loFxFb3JDtMK+xRp3I546SfemgOnV8MN6xzYABA/YFEiDGHAmKt5JoUeGl91exRcEh 7CdsrM1i7xVHXUGwc/BXjAb9s1o0qW5qu+GpKK0XIKf78UWQseTtNFwaGeCAQCLTDZhQ GJ+bJDKMXyowWE9of4Cq2k7rUiwD/cppUI52zdkelo1foP3A8+tmneVBlCXcgDq8wPeG nkZ0jKiJSLi+w4Zgo3ziUqDOCpOZEgOkarClifqETMLLsQzmJbwCEpAtjkDtYHA8N6k/ W1ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="vEF7nV/D"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c18si329226otj.33.2019.12.29.10.35.18; Sun, 29 Dec 2019 10:35:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="vEF7nV/D"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727400AbfL2RWq (ORCPT + 99 others); Sun, 29 Dec 2019 12:22:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:39336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726896AbfL2RWl (ORCPT ); Sun, 29 Dec 2019 12:22:41 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 54A4D208E4; Sun, 29 Dec 2019 17:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640160; bh=RYmowlJo6ZVcEXr9mFpC7tsWQwKALw3DwW8D/1geqko=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vEF7nV/DNDWaRnZAJPu66aJo+fRZBj40uZYQTTk+C/t4nNQEqePbJazOitOYuUoUT /w88y5sPi4Zz77EuBLG87YNd2837pWMMv3XoWko++fRQXFkcqo7x5gj54ycTmly8re YNH5Ccix8z6H2w5b1iDDThunWdqeXsMC+GksHYG4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Cristian Birsan , "David S. Miller" Subject: [PATCH 4.14 008/161] net: usb: lan78xx: Fix suspend/resume PHY register access error Date: Sun, 29 Dec 2019 18:17:36 +0100 Message-Id: <20191229162358.066003285@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162355.500086350@linuxfoundation.org> References: <20191229162355.500086350@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cristian Birsan [ Upstream commit 20032b63586ac6c28c936dff696981159913a13f ] Lan78xx driver accesses the PHY registers through MDIO bus over USB connection. When performing a suspend/resume, the PHY registers can be accessed before the USB connection is resumed. This will generate an error and will prevent the device to resume correctly. This patch adds the dependency between the MDIO bus and USB device to allow correct handling of suspend/resume. Fixes: ce85e13ad6ef ("lan78xx: Update to use phylib instead of mii_if_info.") Signed-off-by: Cristian Birsan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/lan78xx.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1765,6 +1765,7 @@ static int lan78xx_mdio_init(struct lan7 dev->mdiobus->read = lan78xx_mdiobus_read; dev->mdiobus->write = lan78xx_mdiobus_write; dev->mdiobus->name = "lan78xx-mdiobus"; + dev->mdiobus->parent = &dev->udev->dev; snprintf(dev->mdiobus->id, MII_BUS_ID_SIZE, "usb-%03d:%03d", dev->udev->bus->busnum, dev->udev->devnum);