Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13388014ybl; Sun, 29 Dec 2019 10:41:01 -0800 (PST) X-Google-Smtp-Source: APXvYqwIdesR/9OzCyUWTSL2jWtgTo1uLHoVFyJH15tfaiQHEyZACVfyTiQS4L8KL09NiNqn2iu4 X-Received: by 2002:a05:6830:16d1:: with SMTP id l17mr48519883otr.21.1577644861235; Sun, 29 Dec 2019 10:41:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577644861; cv=none; d=google.com; s=arc-20160816; b=bCYu+VVefXZ/EXX0MnrSjqGGLKV/HzGQu0k/Qvws9Cn10snYtsyfuQ2vfSY9wgEl1R S+jICkNPFxJR2gDHFSAF0SdCpCLX0k3wrRqbWoPr281PvjJrzHbloU0ANOuLBM2iwibB xMH35nmhVLka5HmiSDFzT6c05m7ltAC3W1zICu5pHOUvHLZwh5qfnU+fj7Hv0vS9KLrR PsFkqdAfdsDQxd6Au0JNQrP2IUb825N9E4dXFCf3MP6XjHdLtKGfvVKdFJ5gs72K5zdI XRSIeBHkrwOaFBZ1i1ocRgAfDUVgQQiEga/4tV/Tbsy23uzfllUJCCHlBgYVrI7Tt7av gt9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Cmp2XOcowmsqtAiY/Cp60fQLLcQBMud3FpkLq60iMt4=; b=o2MfYGCCBatsPivZNG0qARBKFZ/7kq9FWxqiQdM3Eb8eoDczjwmSYlQk8k397DdqqT 7vmVTPBmeqoTTBkUGhfZqmKV3Bls6QzGqNRLToU0/enSTdY17mXv3s6jRF5ulElXwOzN W8T1/RaHmzqJy/9+N8L0dP1GUQ/nbNfxL6t+6pPWytuOfit3TqQwnn8hKITbJLouRsxq 68iEvlP1jwYmoGUM6PjT8uUB18ORygBQ6AOXCQxK/QGLXtRCiolnO+KY6QWuQiWlWCZL zxQhsElUGH5f0zEyk8qgHdUyJhBo4lV2ONztauEtp/KI+MndFX/kNG5Q8NVKURIvwtBw UCKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SHVD1XJD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l14si13498231oic.222.2019.12.29.10.40.50; Sun, 29 Dec 2019 10:41:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SHVD1XJD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728214AbfL2R03 (ORCPT + 99 others); Sun, 29 Dec 2019 12:26:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:47540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728203AbfL2R02 (ORCPT ); Sun, 29 Dec 2019 12:26:28 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DAAD22525; Sun, 29 Dec 2019 17:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640387; bh=THYdH20xi2zZdRYjzPnZZrm2s1TXvlBcyPXfCrnljyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SHVD1XJDrgKBeA8fy7Yj5I7WYnuseMbv8p2LklUwszyydwbdphOsltHhnu1TaoxGL zvR3ib7LkokI4okiTrvdDRplhMAepdCuibE1mz2sk+rxCjqoezpvPfv2aCY0PZPO59 BSYGEGNREZ0w33LPVtbxTCUGMQQhIwm2GwqwAVME= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Faiz Abbas , Adrian Hunter , Ulf Hansson Subject: [PATCH 4.14 138/161] Revert "mmc: sdhci: Fix incorrect switch to HS mode" Date: Sun, 29 Dec 2019 18:19:46 +0100 Message-Id: <20191229162440.872158709@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162355.500086350@linuxfoundation.org> References: <20191229162355.500086350@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Faiz Abbas commit 07bcc411567cb96f9d1fc84fff8d387118a2920d upstream. This reverts commit c894e33ddc1910e14d6f2a2016f60ab613fd8b37. This commit aims to treat SD High speed and SDR25 as the same while setting UHS Timings in HOST_CONTROL2 which leads to failures with some SD cards in AM65x. Revert this commit. The issue this commit was trying to fix can be implemented in a platform specific callback instead of common sdhci code. Cc: Signed-off-by: Faiz Abbas Acked-by: Adrian Hunter Link: https://lore.kernel.org/r/20191128110422.25917-1-faiz_abbas@ti.com Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/sdhci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1635,9 +1635,7 @@ void sdhci_set_uhs_signaling(struct sdhc ctrl_2 |= SDHCI_CTRL_UHS_SDR104; else if (timing == MMC_TIMING_UHS_SDR12) ctrl_2 |= SDHCI_CTRL_UHS_SDR12; - else if (timing == MMC_TIMING_SD_HS || - timing == MMC_TIMING_MMC_HS || - timing == MMC_TIMING_UHS_SDR25) + else if (timing == MMC_TIMING_UHS_SDR25) ctrl_2 |= SDHCI_CTRL_UHS_SDR25; else if (timing == MMC_TIMING_UHS_SDR50) ctrl_2 |= SDHCI_CTRL_UHS_SDR50;