Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13394907ybl; Sun, 29 Dec 2019 10:51:24 -0800 (PST) X-Google-Smtp-Source: APXvYqyJL5lJyjlr65hbPlGicStZDTIaSBZC61SXQw+90uhbxb0dkUFw4ukwJqL79PaKS4nUdxm+ X-Received: by 2002:a05:6830:1607:: with SMTP id g7mr70047026otr.320.1577645484413; Sun, 29 Dec 2019 10:51:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577645484; cv=none; d=google.com; s=arc-20160816; b=09rGZhO7t7KTr5oTEegdL5b1KcRtAjQkqVEIdhd1LeozY9mAyea3XbZf2RvtrDZpCd 8XXPmQtE4kdLTzKZhZATzPk7ylo2nToxAUoxZ+/nFkbdQp3ww9Q3pTMEsdtGfEeTzWJ6 3E6DgrYHoxfNSSRH3Uy9fAqI/eu+JusEvGhHQ+paGLgSHFPXiuDcxX6mdzdSqWvbh9Ky pnm3TjG/22G0WS82cuqqZHeyCDvRok24joqZJNTwu2FH2NaEKF2hD9Ie/IgW0VkJV7JJ Xbu/xVjMTg5YxNLUg9XnR4M2CXCzN+Rg/Q4nr/EWv+rCE9jj1bEeYS9fMAJ0dVwqwS48 cxdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Pcec+Co7iyagba9ElROmLNTWuTvMMmno/fAl/anPS8s=; b=JdBt77uug1f3pvxWj2yEXmBhjm9nnzkkU3oazlYsApOwa84cKI+mzLuq+eUosfmW8j /XUSI2+Wd4ywkyP9Yt9luAhQJGpAsOms4AsnS9hSuLvv+GvGcu6o3SsGpLs2ADLsNTCb nAbSZlJ0Ap0gu6m04YUIgcXUXHrACQp2/b5x6lzCSeQGzj1mGYTa+YFiGCmKMNQm/DpS 4y62q5SPuiIfCBmqV5D0VR6EGhAOFsqMzSp0PKXP9pC3hQMDZDYTcvygYGpiVHociVKH n6IpvkR+98Vl6wA+qBV211MbVgWrAEEhVtSRUCrITYbZrAC+izZcXuSIcfhDUTxgbt6Y HIRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=b6tawmtd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h138si19636916oib.6.2019.12.29.10.51.11; Sun, 29 Dec 2019 10:51:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=b6tawmtd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728678AbfL2R2y (ORCPT + 99 others); Sun, 29 Dec 2019 12:28:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:52638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728659AbfL2R2u (ORCPT ); Sun, 29 Dec 2019 12:28:50 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2339207FF; Sun, 29 Dec 2019 17:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640530; bh=nMaQmfACss/jy3HnBrRn9mpVLBHDdBvmtGOMhDk4xhA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b6tawmtd7xPIuZbmO9uda20ujFquvAVGEDlYuDLtofsvTBLHMe2rr8WNuWgEIdM6Z IE+mcHrLF+AojlQi99yRcKnVXkhaWdpt693JP/tcgI3aY+tVYf8Azi7bEAl0TC8hE2 hkZ7RQX3I8vk5K3feJkJwBBKCpzSdyTwTfGQd82U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lukasz Majewski , Mark Brown , kbuild test robot , Sasha Levin Subject: [PATCH 4.19 032/219] spi: Add call to spi_slave_abort() function when spidev driver is released Date: Sun, 29 Dec 2019 18:17:14 +0100 Message-Id: <20191229162513.286262453@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162508.458551679@linuxfoundation.org> References: <20191229162508.458551679@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lukasz Majewski [ Upstream commit 9f918a728cf86b2757b6a7025e1f46824bfe3155 ] This change is necessary for spidev devices (e.g. /dev/spidev3.0) working in the slave mode (like NXP's dspi driver for Vybrid SoC). When SPI HW works in this mode - the master is responsible for providing CS and CLK signals. However, when some fault happens - like for example distortion on SPI lines - the SPI Linux driver needs a chance to recover from this abnormal situation and prepare itself for next (correct) transmission. This change doesn't pose any threat on drivers working in master mode as spi_slave_abort() function checks if SPI slave mode is supported. Signed-off-by: Lukasz Majewski Link: https://lore.kernel.org/r/20190924110547.14770-2-lukma@denx.de Signed-off-by: Mark Brown Reported-by: kbuild test robot Link: https://lore.kernel.org/r/20190925091143.15468-2-lukma@denx.de Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spidev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index c5fe08bc34a0..028725573e63 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -634,6 +634,9 @@ static int spidev_release(struct inode *inode, struct file *filp) if (dofree) kfree(spidev); } +#ifdef CONFIG_SPI_SLAVE + spi_slave_abort(spidev->spi); +#endif mutex_unlock(&device_list_lock); return 0; -- 2.20.1