Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13406357ybl; Sun, 29 Dec 2019 11:07:44 -0800 (PST) X-Google-Smtp-Source: APXvYqwxBTVdsb1m3lMoKx42gXu/FiDUF06ICH4AgWX0A+yhAqe9ht2qc1peq84xsHwtNDr5bUmu X-Received: by 2002:a05:6830:1294:: with SMTP id z20mr67713739otp.60.1577646464533; Sun, 29 Dec 2019 11:07:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577646464; cv=none; d=google.com; s=arc-20160816; b=vnGEjD1aGbEpxjSD9rfx/FgPtKEEtgirwKdqKVkVl0fPL/yvtK5Fh9nec3ftBybLgq Xhhyp7ATeTD15M8NFK+0m563A1UHE5XNFZcrlEsvmq5UyNmJciyhbWfbKYGclVhq2q7B veXMS5lpx3xOWN1fPzZT0ecL9u+dz3FRMVyLDftxgUQs7wT7ycQ4V0raD3w68Eg9EgaA q9k9ZqdmWiz/GK0y9q0eLoLPPbUwj1Y9jKSkt82z4auFKhY8izdN3fVStA8lKhnsnnbS 23+WDbPo4J6dYrGpaJUFU7KZui9NwKmefT7iKDcl6LXDQoSi7+jOhtxqWYDbtLpoXdam o19w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Oie7f3AWm6rbR7Q5KWd3cDZ2x0TXEexLZ6utd8FtbVQ=; b=YH2fbsO+pLcwLBoIyhvIitJSzx1U5dfloBBic+2l1SVIjpbsi3yytubxXeCxD+V3JR k+1hdojZfO/ebAwUV6fgVtxEC/eBDZbkwtyyk4tcl03dXBjpLPl8DSsQhsO9Iq17mMyH o486LpsWnxJ9I7htqPDM4K6UxlwiO6qvxKhPQDSFqMOWwG242TZZeAAxRI4ej7rqDs0v YyU2x+ju+DnYv3XJfgLdqH94C8SxbxaVTfbqE/nubfRUtc2LokIdgzyMQZtwcVSUDZ/U 8Iqis3IBMJFvlIMIUWXBi3aWW9lK+8qVHnQ+6o2zpqwvY12XoqMWWIOqDiuZYrJxE7+4 IApg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lgBz6sGP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7si18599525otk.86.2019.12.29.11.07.32; Sun, 29 Dec 2019 11:07:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lgBz6sGP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727772AbfL2R0F (ORCPT + 99 others); Sun, 29 Dec 2019 12:26:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:46558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728103AbfL2R0B (ORCPT ); Sun, 29 Dec 2019 12:26:01 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B17FF22B48; Sun, 29 Dec 2019 17:26:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640361; bh=EdmkhEuQ/FOnFOegYYoZ0ze6bpaMjHBO2oZxRrqV5wg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lgBz6sGPYT2PMdliEOy4DGBhgaZJ7o1Qc8uwV/A5D0hIh4ZVIKaNiQXTttEr+Xdk2 6NtiP2NgMywrVDg+yaenJLvjo0zzgURPs2N74PLNKdIqM/H/0ZcPNpxKVJz4FMIdPx fjygJ/xWDehIxCGOYxpoEw7SXxJ0oO9B4IXFOjmY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Manish Chopra , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 088/161] bnx2x: Fix PF-VF communication over multi-cos queues. Date: Sun, 29 Dec 2019 18:18:56 +0100 Message-Id: <20191229162425.208220935@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162355.500086350@linuxfoundation.org> References: <20191229162355.500086350@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manish Chopra [ Upstream commit dc5a3d79c345871439ffe72550b604fcde9770e1 ] PF driver doesn't enable tx-switching for all cos queues/clients, which causes packets drop from PF to VF. Fix this by enabling tx-switching on all cos queues/clients. Signed-off-by: Manish Chopra Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- .../net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 9ca994d0bab6..1977e0c552df 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -2389,15 +2389,21 @@ static int bnx2x_set_pf_tx_switching(struct bnx2x *bp, bool enable) /* send the ramrod on all the queues of the PF */ for_each_eth_queue(bp, i) { struct bnx2x_fastpath *fp = &bp->fp[i]; + int tx_idx; /* Set the appropriate Queue object */ q_params.q_obj = &bnx2x_sp_obj(bp, fp).q_obj; - /* Update the Queue state */ - rc = bnx2x_queue_state_change(bp, &q_params); - if (rc) { - BNX2X_ERR("Failed to configure Tx switching\n"); - return rc; + for (tx_idx = FIRST_TX_COS_INDEX; + tx_idx < fp->max_cos; tx_idx++) { + q_params.params.update.cid_index = tx_idx; + + /* Update the Queue state */ + rc = bnx2x_queue_state_change(bp, &q_params); + if (rc) { + BNX2X_ERR("Failed to configure Tx switching\n"); + return rc; + } } } -- 2.20.1