Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13426221ybl; Sun, 29 Dec 2019 11:35:40 -0800 (PST) X-Google-Smtp-Source: APXvYqzZBwl+GisgKION386dqtMFWoA9BAV9T/6i9eEKe6UUvmLAAip4UFZ6Od5x8lkQs53hIBmq X-Received: by 2002:a05:6830:1d6e:: with SMTP id l14mr69644515oti.32.1577648139980; Sun, 29 Dec 2019 11:35:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577648139; cv=none; d=google.com; s=arc-20160816; b=lznL/w58yomf+LzmmJnHfj0/k21Fb2XSP0rU02NgJvHHr3SvyElwLjsA/w+SByAj1p KKZjsoY1LPA8SPGOg6EPFJt8RQMtFnPb0pM+bcxe+WXcrEX4JgSclc3wDVg7x0UQkupr JRmwRbMbpCmIGPNRqm3+1ZIUUaQeB4zCBGJByQFXjX5Zl/wxqDlf7oW90UoW4YMXJ5E+ 0hsOLiG+P8Oi2xpyIG2J4ENAUAK7yeViMThyEQQt7TkxZpy+YW+Sygrx7Ct6c9zdy+iL LIb/mDGx8M7MHLZMgAFhSrexMlbaN7r/ZmVaaoxgQijxS2P3gQtxkO0IFEolmp4M9CgZ MHKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8nM4oPzBznc/E/NatSLtX8SMBKOgI+GfAqdaRe1xOeA=; b=x526ov9EbRNiB3rOSejqL+UoY29SMhCYqSeAu/5FNR3Lg1k7Wup1wwRiDXiCZtMc0r wfbSmg/mV79NcIuCYwfx7G3Talgl9MH4QKqDnaedQvUDKI1ZkHf8ZGYjcok9xOIPxUwZ MzwEC3kMd3FJfOC76XDf2ccIA+Nj1Olll8djdgcElCG1nZhaSGWhgeZJx+n+wUHHfP0v nil7JJQLrQ+0pavpmh05TlY9ue8bjweAX2fhA/hbHR3ZSBOKh83u5rzVhL1agb+KfPSS v/r3BZMtuyG/M0eIDXoHF3Hgi/IQmpnS0REjyWxJ6hV5HMaGpdJ8kLnkCCFiSUPrrHXj wz1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jZeUldcF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q66si18827371oig.65.2019.12.29.11.35.27; Sun, 29 Dec 2019 11:35:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jZeUldcF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728927AbfL2RaM (ORCPT + 99 others); Sun, 29 Dec 2019 12:30:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:55554 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728843AbfL2RaE (ORCPT ); Sun, 29 Dec 2019 12:30:04 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0821A20722; Sun, 29 Dec 2019 17:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640603; bh=2mELMA7+IYIye6ehOomFskH1dETTtE40+RJWTuQmDBQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jZeUldcFHKiU12FPzu7N4yNWvwTqZ9ZJZMoXe7cKWycypChz8HsLc5oZhFbXGN0AD b5oCC5zzCgenkI7fG3ZowLkcUpM8EpxJ4Igg/V69D0gn5Kc9h2ve17BA6Fso2Y8gvz Onp9wVW6HwYyssStEhwK+eHMQSqNCjVJXzMNl2O8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Loic Poulain , Stanimir Varbanov , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.19 046/219] media: venus: core: Fix msm8996 frequency table Date: Sun, 29 Dec 2019 18:17:28 +0100 Message-Id: <20191229162514.740141876@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162508.458551679@linuxfoundation.org> References: <20191229162508.458551679@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Loic Poulain [ Upstream commit c690435ed07901737e5c007a65ec59f53b33eb71 ] In downstream driver, there are two frequency tables defined, one for the encoder and one for the decoder: /* Encoders / <972000 490000000 0x55555555>, / 4k UHD @ 30 / <489600 320000000 0x55555555>, / 1080p @ 60 / <244800 150000000 0x55555555>, / 1080p @ 30 / <108000 75000000 0x55555555>, / 720p @ 30 */ /* Decoders / <1944000 490000000 0xffffffff>, / 4k UHD @ 60 / < 972000 320000000 0xffffffff>, / 4k UHD @ 30 / < 489600 150000000 0xffffffff>, / 1080p @ 60 / < 244800 75000000 0xffffffff>; / 1080p @ 30 */ It shows that encoder always needs a higher clock than decoder. In current venus driver, the unified frequency table is aligned with the downstream decoder table which causes performance issues in encoding scenarios. Fix that by aligning frequency table on worst case (encoding). Signed-off-by: Loic Poulain Signed-off-by: Stanimir Varbanov Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/qcom/venus/core.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c index 5b8350e87e75..60069869596c 100644 --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -430,10 +430,11 @@ static const struct venus_resources msm8916_res = { }; static const struct freq_tbl msm8996_freq_table[] = { - { 1944000, 490000000 }, /* 4k UHD @ 60 */ - { 972000, 320000000 }, /* 4k UHD @ 30 */ - { 489600, 150000000 }, /* 1080p @ 60 */ - { 244800, 75000000 }, /* 1080p @ 30 */ + { 1944000, 520000000 }, /* 4k UHD @ 60 (decode only) */ + { 972000, 520000000 }, /* 4k UHD @ 30 */ + { 489600, 346666667 }, /* 1080p @ 60 */ + { 244800, 150000000 }, /* 1080p @ 30 */ + { 108000, 75000000 }, /* 720p @ 30 */ }; static const struct reg_val msm8996_reg_preset[] = { -- 2.20.1