Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13471580ybl; Sun, 29 Dec 2019 12:42:31 -0800 (PST) X-Google-Smtp-Source: APXvYqwGcP+wh7d5UoLXOIHXmM7np3lkGoEelCVhlTu0jNnUc8iCget7cWK3YvZjDDLk7Lgght/T X-Received: by 2002:a05:6830:1401:: with SMTP id v1mr39616137otp.360.1577652151014; Sun, 29 Dec 2019 12:42:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577652151; cv=none; d=google.com; s=arc-20160816; b=B6iatyXVtPRPxaWqv71E9/HcGaD1n8brY//lVPt7EO2qnd/kZkD90OknQwa9ljd+wG Tn6DsZ9BfTenqccL+8kkeJIGG/XZKZAUchVfQ9sIJcybMvd45FIfZElwhtZAZX32tnpG jMtAtD8OO4ZGoNgZgg4SmK2gx6DaNQ2L/xxLiS2HtFqQVy3MsBmgNa0Dt6SaNN54pbP4 SRGniEEx13TVTUK7pxYjkHxBoSeEmvJP0Ef7829t2Pozkrg6XRhBwfVsxoPK7UwM74Fk SkxsmTSjAfeZ1Hcat02yyXkMO5fJDZZxApGW9PDC3ZrPd/zwaUANp18FdoKjxqNPJSlJ dT+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=O78bVX/vdRvouW5DnZLhc7s8ZS9OvqJOpM1Bi6vjtgU=; b=zPukELJoIP4iJVZgk2pyJJRqG4PZTNkCnKFLLCicSvLaYALRDQAromStT/+IBcnPc9 nTnLzBjKrqwu51CZO0HJ0TKfURHgN9uglf9UfsMRhachfk9m0w8sCHUSXokI3vKO7xVb pcoVtg1GTMlYK43zi82JfDEpMmRqmp/RBlvYqYtTwr3BftWEaym/vguIWE2FZnz4apbs m7Ilcl2n5Kh0xLbEoD9wNWbIUqzXekiRgrC/iT0PbmM9aj2Zk2WshOrhJiVNSJo2g4GD tMGEhLhnCN0lDf5daH9IEIWG3MpTcxYquhe+GZBF5gVgqP56UOmeR3yPDYQMiJijTw2y Mz1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VrlH3Stk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p16si23476400oto.287.2019.12.29.12.42.19; Sun, 29 Dec 2019 12:42:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VrlH3Stk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730233AbfL2Rlz (ORCPT + 99 others); Sun, 29 Dec 2019 12:41:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:47618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729235AbfL2Rlw (ORCPT ); Sun, 29 Dec 2019 12:41:52 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49709208C4; Sun, 29 Dec 2019 17:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577641311; bh=3LB8rqRiyIvwRRLvI8gR+OWS2XUtX3mgWIjjIKtzew8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VrlH3StkGdhcGp+W/1439L1mJEt3kMVDL0NTiV8qooa7Hn2C+OImbx2eogM7TAaib Ui4E5BR6Fal3GOuDzDym8GpEL42+OGUgCjaHsq39GeBizXeJ77q3RUgkoUV/KQ5/q6 AumAC+zpO67z6tnPCPpaeJIHyAo1k+eC+V2yLRE4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Manish Chopra , Ariel Elior , "David S. Miller" Subject: [PATCH 5.4 014/434] qede: Fix multicast mac configuration Date: Sun, 29 Dec 2019 18:21:07 +0100 Message-Id: <20191229172703.177400781@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229172702.393141737@linuxfoundation.org> References: <20191229172702.393141737@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manish Chopra [ Upstream commit 0af67e49b018e7280a4227bfe7b6005bc9d3e442 ] Driver doesn't accommodate the configuration for max number of multicast mac addresses, in such particular case it leaves the device with improper/invalid multicast configuration state, causing connectivity issues (in lacp bonding like scenarios). Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qlogic/qede/qede_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/qlogic/qede/qede_filter.c +++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c @@ -1230,7 +1230,7 @@ qede_configure_mcast_filtering(struct ne netif_addr_lock_bh(ndev); mc_count = netdev_mc_count(ndev); - if (mc_count < 64) { + if (mc_count <= 64) { netdev_for_each_mc_addr(ha, ndev) { ether_addr_copy(temp, ha->addr); temp += ETH_ALEN;