Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13475238ybl; Sun, 29 Dec 2019 12:48:23 -0800 (PST) X-Google-Smtp-Source: APXvYqyF7QX19j07MSZ9fxx+WZmuXd7NwRGD37S/iryyr+rZRUL+D0DWVlaz1T7V2T2uEXjaZkWQ X-Received: by 2002:a9d:8f1:: with SMTP id 104mr65327117otf.107.1577652503430; Sun, 29 Dec 2019 12:48:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577652503; cv=none; d=google.com; s=arc-20160816; b=md7DMA2KEtfqB9I/+OiBD2Ku2El1X+2yyal/kDpeHIZ05ZLDO/5i4pl1xTLs51W+8A kNQbm3ARTKfzA5f8823h0DLPciYsUg+fNhCXBjXu40WCDUEtpvp3PmYt6+PFOvDud8Dv wJH1GtOL3UXCx5jGbQ2MsGnHOHZYlWdS1220kffHarXvMQYhkjfJh6zfjGZ+5UuOYqki S+cPbVwf1+YHMlfX8bF9Peip4l9+ng1NPTG1a4ToLHMJIi0MQvro6KETZl+v47/7Glww UM1KcKs0Ypy0hSp6JjQVw/FOLxj5nhAxaWkmFu7+nz6TJSD+koD2JNT85Dvjocsy1auF b/QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7VLOvjNvM0j3w+6kzPJ4u//ynt+EYl2Lz4Q/PWtrZhg=; b=lvVnbTikIrGje9iQRrJqJPMLiaeVt0SOlR7R6gZHqWWlCLwCThkzt46eevXcmiH8t3 id8rxgsKnvEDPOxqRdId8n4ZRqC1NHJx+wT1llcYTE2u2nvdXTsK0+7w07dfAqaBpOfI bXOC5mM7X5hdSNXwpB1CpjCVnAjdZW+/NrgTBIZon2aACDdfW7xL4OQ8ncEDMxUbycaP UL6W6qdTa5eP5M4QgVfRzfHe+Gf59oQCv0/bliSpRSelIEcdqhp239CGiRWFHPBMw/Tm 7FfYtG9zdGVl8+NqUeFm/9wvMOB144LmbHEE6okL2k7+FkBKIodjLoBuyeHnSDvgYD8h eHEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bCPSCsTm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 5si19361116oiy.102.2019.12.29.12.48.12; Sun, 29 Dec 2019 12:48:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bCPSCsTm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732673AbfL2RyT (ORCPT + 99 others); Sun, 29 Dec 2019 12:54:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:42034 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732661AbfL2RyS (ORCPT ); Sun, 29 Dec 2019 12:54:18 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8857520748; Sun, 29 Dec 2019 17:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577642058; bh=Xy4RFfpP7UI71FN0VoyEB6JUALuIPsi8J5H+6qZxt5k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bCPSCsTmgsYLO5MEEUYL0AWlvynV7MbvmOfUEPj0uD5OlBznJY956S4tC7cI4m9Au +mBEKSvS/XVavnxSYfsiVQnS7JomYTsvAF3lB5t3oc4rcmfdQEWC5DDt7r6/vztYQn iC2v+ca+3cHV1Zh7AFO6uZskm+VAPUJiAhr2Ww5o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Charles Keepax , Mark Brown , Sasha Levin Subject: [PATCH 5.4 322/434] ASoC: wm5100: add missed pm_runtime_disable Date: Sun, 29 Dec 2019 18:26:15 +0100 Message-Id: <20191229172723.357824314@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229172702.393141737@linuxfoundation.org> References: <20191229172702.393141737@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit b1176bbb70866f24099cd2720283c7219fb4a81c ] The driver forgets to call pm_runtime_disable in remove and probe failure. Add the calls to fix it. Signed-off-by: Chuhong Yuan Acked-by: Charles Keepax Link: https://lore.kernel.org/r/20191118073707.28298-1-hslester96@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wm5100.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c index 4af0e519e623..91cc63c5a51f 100644 --- a/sound/soc/codecs/wm5100.c +++ b/sound/soc/codecs/wm5100.c @@ -2617,6 +2617,7 @@ static int wm5100_i2c_probe(struct i2c_client *i2c, return ret; err_reset: + pm_runtime_disable(&i2c->dev); if (i2c->irq) free_irq(i2c->irq, wm5100); wm5100_free_gpio(i2c); @@ -2640,6 +2641,7 @@ static int wm5100_i2c_remove(struct i2c_client *i2c) { struct wm5100_priv *wm5100 = i2c_get_clientdata(i2c); + pm_runtime_disable(&i2c->dev); if (i2c->irq) free_irq(i2c->irq, wm5100); wm5100_free_gpio(i2c); -- 2.20.1