Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13476652ybl; Sun, 29 Dec 2019 12:50:16 -0800 (PST) X-Google-Smtp-Source: APXvYqycyNVrHLHDyEKQaAgZ2FQ0ZqnoiMaeE7cbw35dZCZkvFKUf6GVg7gN/ujcZvcRJmO2GhEy X-Received: by 2002:a9d:7e8a:: with SMTP id m10mr66922643otp.27.1577652616707; Sun, 29 Dec 2019 12:50:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577652616; cv=none; d=google.com; s=arc-20160816; b=Qlooy0AvzUmSZLbYX5W5gX2tMPw3Ug0/8/veyjcL1nDzwvDJuL8rOAcJ1w6JOJtYQY 9fy2UXwphPF33lOFWggsPL9UaefS2ndgSruZiXGfe8M/QjNCMsvATuqCwGtq9awvXXwL xNI7yNtUTrhcAhngtLbA0MmeoZc48tr49ifD74mj7XQKEYJ3uEF+L5bnfzdYRmSUsq1o xIjLD6BuF242rhIAt5hO1RluMfq8fmk9CVilc+UevDrGrwR7FIZ5klT84qpmQIAeXSWE F51phkYN4G8znhGMptLyDpi3MwBJofmYt4i6nJA9gxKYqVMGf5EUF6TqzxagvZ0uoKSb OTIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lIRakVVPlkNt5ciLnOZnRINoQOdNwrgTs6y5YcY2k6s=; b=szAch24E01eDW1sbKV7L0+OVL+SJLrySTyLsqoJSXTGLu7ym+XbYdPhkaMfQiMXRQ9 L0NUEco+H17ZZ0Jy0metODwAI82gok/0UUJdoiJ9aXjgdIbWeBG/JEmM/6jJPO0SAgfO 9ik7kglsgyYyvzhdS1mrmNxnwrvtxfjPRhqpKLHmS0f8CFQ85stYWTlAhgjsVR8ObF2o jEaLkZH08nbl8UTIOB3vaymvrxKbxp58WVjdEbyEFhKZoowkzc/f8nsgE0LGin4gsq2W zFPicDbnHpLPJUophG61jalEu2L1AObxtICqH7PyRU2p11tD+ilv0Ux6QPBLbAmY4kve z3YA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ldjUSQmr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e15si13713853oti.29.2019.12.29.12.50.05; Sun, 29 Dec 2019 12:50:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ldjUSQmr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387670AbfL2R7H (ORCPT + 99 others); Sun, 29 Dec 2019 12:59:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:50604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387665AbfL2R7F (ORCPT ); Sun, 29 Dec 2019 12:59:05 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 33854222C4; Sun, 29 Dec 2019 17:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577642344; bh=0q8c5ipVUwa36yOLxowJrJaNfF7tA69u9fVKLVZ7p2w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ldjUSQmryyK5FdzosQkMfU7stMgAvDL7Zv8IAElAHsl0XdaFIsMVYYn9jIhMwlwIi Wyr7vqNE9Ek7xYMcNt+Dc/SaJlKhbf155OWqQ2fHXRizuYlyy7hnWHVsveON45dHsf NHz6lvTVDl0TOy/byRDm/r6xytams6MUZF/UVJIc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Benoit Parrot , "Lad, Prabhakar" , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 032/161] media: i2c: ov2659: Fix missing 720p register config Date: Sun, 29 Dec 2019 18:18:00 +0100 Message-Id: <20191229162408.192311973@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162355.500086350@linuxfoundation.org> References: <20191229162355.500086350@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Benoit Parrot [ Upstream commit 9d669fbfca20e6035ead814e55d9ef1a6b500540 ] The initial registers sequence is only loaded at probe time. Afterward only the resolution and format specific register are modified. Care must be taken to make sure registers modified by one resolution setting are reverted back when another resolution is programmed. This was not done properly for the 720p case. Signed-off-by: Benoit Parrot Acked-by: Lad, Prabhakar Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/ov2659.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c index 04d493aea45e..44b0584eb8a6 100644 --- a/drivers/media/i2c/ov2659.c +++ b/drivers/media/i2c/ov2659.c @@ -419,10 +419,14 @@ static struct sensor_register ov2659_720p[] = { { REG_TIMING_YINC, 0x11 }, { REG_TIMING_VERT_FORMAT, 0x80 }, { REG_TIMING_HORIZ_FORMAT, 0x00 }, + { 0x370a, 0x12 }, { 0x3a03, 0xe8 }, { 0x3a09, 0x6f }, { 0x3a0b, 0x5d }, { 0x3a15, 0x9a }, + { REG_VFIFO_READ_START_H, 0x00 }, + { REG_VFIFO_READ_START_L, 0x80 }, + { REG_ISP_CTRL02, 0x00 }, { REG_NULL, 0x00 }, }; -- 2.20.1