Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13477169ybl; Sun, 29 Dec 2019 12:50:59 -0800 (PST) X-Google-Smtp-Source: APXvYqzZ0tAMWzT+QIdP/lu8B3Ny92IplhEqKvE15nLQo5m4YA1LjV2kMpy7MPef/hVlqbcvyuL8 X-Received: by 2002:a9d:6b12:: with SMTP id g18mr68076400otp.211.1577652658886; Sun, 29 Dec 2019 12:50:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577652658; cv=none; d=google.com; s=arc-20160816; b=IG00CoeCbdF47ts9OY+JbEjxhUy/VlCioF5nttZ88GlO74ide/rejM9MS3FuRhzyks aQdBfx7ZjlkM6NcXvRr3iFTC25uGG5JdNAyUy9kFINyTLhwXMuCbHlFl4lWfLif5L3gH J2PNZs4Jq/JQzZ8sNqU93Ljp70rUh3/ZDzmQO3US+zaVKeyov4Yf/wrj4PYT8IcJvEs0 JTMUook5ITNjgGCO2lQ1npRuvO2Gdyk7O9N8bNQKzOpd4gXZP0Nn/w8+DaoSfyyhKetb 5deIDF7gPcrcBBngJR66tL+Bori83NFr6vkSuqnspk61RHLxHIOnH0WSezv5fyaQgssr RqMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MxUPWi7BRa7mEntgM8oDULWG+XN0hNioRu7iSsYoXIo=; b=ZnCgXnHDkWGyuvALNfXpluxM5dSV57U1/+n4e2E9cM+G2SLbJaIlrjCYAJV6d515/a r57zEphCn0wZgL6M/MbYQxIDLNDVG+FDlOQlXWeRyWqntXSk05Czktjpdg4WNPqP7FYM vvmsFUqCJzI6Q/VdvoY2jUxYbst3TavYkWMq2JdB6k/2Ogm2vJB0XvS7yWKq9AzPSv0k Z6zZcians4pQj6xMDmJFg0ZngT9WPDAH/rhNc7puDzezI46PWes0pDJDBy8sXQGP1DZE PdvAppe8ty705rif4HhhjuekTjJJVOvUsuEKOzLldn/EZgVMDRSKQgLIPbAvHh0B0Rwl iJSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SLtB6fRN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t14si16315117otp.210.2019.12.29.12.50.48; Sun, 29 Dec 2019 12:50:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SLtB6fRN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731262AbfL2SIN (ORCPT + 99 others); Sun, 29 Dec 2019 13:08:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:57902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730985AbfL2RrW (ORCPT ); Sun, 29 Dec 2019 12:47:22 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D203C20718; Sun, 29 Dec 2019 17:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577641641; bh=Kz5HlZjaUT9tX8Eyv4AqnpRGD+ixkkCCZAFsG9IcSD8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SLtB6fRNMqs+KGXxXGOBeiWL2FjcfGXEunAbn1S+Osbj2DW43zckr/hcxuc7vsFAn cJUljm1f2AKlRetFWHpBkgB0DGS0c4cWX5SgnvQRsIAy33S82n87j1rzXS5yIikEhB yALPv42B3GRkOaFXWXIyjNpDp+cNS/QBbbjWZsA0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Veeraiyan Chidambaram , Eugeniu Rosca , Yoshihiro Shimoda , Sasha Levin Subject: [PATCH 5.4 101/434] usb: renesas_usbhs: add suspend event support in gadget mode Date: Sun, 29 Dec 2019 18:22:34 +0100 Message-Id: <20191229172708.307687529@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229172702.393141737@linuxfoundation.org> References: <20191229172702.393141737@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Veeraiyan Chidambaram [ Upstream commit 39abcc84846bbc0538f13c190b6a9c7e36890cd2 ] When R-Car Gen3 USB 2.0 is in Gadget mode, if host is detached an interrupt will be generated and Suspended state bit is set in interrupt status register. Interrupt handler will call driver->suspend(composite_suspend) if suspended state bit is set. composite_suspend will call ffs_func_suspend which will post FUNCTIONFS_SUSPEND and will be consumed by user space application via /dev/ep0. To be able to detect host detach, extend the DVSQ_MASK to cover the Suspended bit of the DVSQ[2:0] bitfield from the Interrupt Status Register 0 (INTSTS0) register and perform appropriate action in the DVST interrupt handler (usbhsg_irq_dev_state). Without this commit, disconnection of the phone from R-Car-H3 ES2.0 Salvator-X CN9 port is not recognized and reverse role switch does not happen. If phone is connected again it does not enumerate. With this commit, disconnection will be recognized and reverse role switch will happen by a user space application. If phone is connected again it will enumerate properly and will become visible in the output of 'lsusb'. Signed-off-by: Veeraiyan Chidambaram Signed-off-by: Eugeniu Rosca Reviewed-by: Yoshihiro Shimoda Tested-by: Yoshihiro Shimoda Link: https://lore.kernel.org/r/1568207756-22325-3-git-send-email-external.veeraiyan.c@de.adit-jv.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/renesas_usbhs/common.h | 3 ++- drivers/usb/renesas_usbhs/mod_gadget.c | 12 +++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/usb/renesas_usbhs/common.h b/drivers/usb/renesas_usbhs/common.h index 0824099b905e..ef1735d014da 100644 --- a/drivers/usb/renesas_usbhs/common.h +++ b/drivers/usb/renesas_usbhs/common.h @@ -161,11 +161,12 @@ struct usbhs_priv; #define VBSTS (1 << 7) /* VBUS_0 and VBUSIN_0 Input Status */ #define VALID (1 << 3) /* USB Request Receive */ -#define DVSQ_MASK (0x3 << 4) /* Device State */ +#define DVSQ_MASK (0x7 << 4) /* Device State */ #define POWER_STATE (0 << 4) #define DEFAULT_STATE (1 << 4) #define ADDRESS_STATE (2 << 4) #define CONFIGURATION_STATE (3 << 4) +#define SUSPENDED_STATE (4 << 4) #define CTSQ_MASK (0x7) /* Control Transfer Stage */ #define IDLE_SETUP_STAGE 0 /* Idle stage or setup stage */ diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index cd38d74b3223..53489cafecc1 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -457,12 +457,18 @@ static int usbhsg_irq_dev_state(struct usbhs_priv *priv, { struct usbhsg_gpriv *gpriv = usbhsg_priv_to_gpriv(priv); struct device *dev = usbhsg_gpriv_to_dev(gpriv); + int state = usbhs_status_get_device_state(irq_state); gpriv->gadget.speed = usbhs_bus_get_speed(priv); - dev_dbg(dev, "state = %x : speed : %d\n", - usbhs_status_get_device_state(irq_state), - gpriv->gadget.speed); + dev_dbg(dev, "state = %x : speed : %d\n", state, gpriv->gadget.speed); + + if (gpriv->gadget.speed != USB_SPEED_UNKNOWN && + (state & SUSPENDED_STATE)) { + if (gpriv->driver && gpriv->driver->suspend) + gpriv->driver->suspend(&gpriv->gadget); + usb_gadget_set_state(&gpriv->gadget, USB_STATE_SUSPENDED); + } return 0; } -- 2.20.1