Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13477611ybl; Sun, 29 Dec 2019 12:51:36 -0800 (PST) X-Google-Smtp-Source: APXvYqxDnn/J60nNeR8PdguZ8QT5HRUk/OEsJTzITENCvg3MHduYYQ8VdahN0uqSylvr+kNBzCnW X-Received: by 2002:a9d:3cf:: with SMTP id f73mr70757755otf.11.1577652696790; Sun, 29 Dec 2019 12:51:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577652696; cv=none; d=google.com; s=arc-20160816; b=TyDyHiPkL5IfUw+kuc1ChLDxhSZbDyOAN2IhylNFPp/Dt9qJHEr6vyPUA5ZfomWvpE OVT5qXMTgXCsnhobxgaoydqE1FZOw2d2oVtMSARcYefzCrMCJHzCSwr08WHcI2Q81+Vf fFKiJWslQ1Ifz+GZ08kDBhB2YAE4M0O0OB3SgoSjvimP4m/tfisclczm3zORmRsWvLit 0r+M5WyEOJjIrVnSaPKyZa8KVP/5zKLU7r3oOiRr684qCzFgXzY/PkLTLyoSAbnWhr0e PGc/1kC0lxGewcRO2q8WZbR5LdhPsG+GMf3AxRUzVpc5wMKJ8LmrUI4RxIsK3OC1eJXd Lbnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IzMbza48g5wKlKyOAHJqblOFS9drXicWlYlTZ+yKeMo=; b=YCvRvCbl44ULnjt3LlsbWE81o6RdCItSi+5VTNPIhMZZPlIw2TgJJsxUQq4D+S2b6R 9dVcgK2d6V3Nr4BUSZFvag/hzbvbun0mA/ubBw+bm+35dDaDrkqRRIn7AHNrTjVA/pxH 6um9SYmUHzdRtiOSsb1kiCKT/x1C7Oi0vDNr2HLHvf5JKwzcavxLoZZIlMD+f2kuGUX0 sQNorbl92cLBlGn+Cka31sbhByWSclmmI0f8RK3EZ6ETTNAQDOAdq2ncM61Bx3qyjF8w ugywF33Zba2FxL1L3qdkvLU45UWZs+GdDRSOHgL2JSH1S3aDyfCpVW5/kZhKDg05/4QQ cdWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C0LpRJuz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k15si16375516oij.134.2019.12.29.12.51.25; Sun, 29 Dec 2019 12:51:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C0LpRJuz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732435AbfL2SOC (ORCPT + 99 others); Sun, 29 Dec 2019 13:14:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:49926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728434AbfL2R1d (ORCPT ); Sun, 29 Dec 2019 12:27:33 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 306D320409; Sun, 29 Dec 2019 17:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640452; bh=8zHvYP0Gzde2DetqxjP/+n4pV0eXIBIfVJDS6jyzJ5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C0LpRJuzKlyxawv2iOG7KkD6ANT65rB45LTEG4ZqqDzSR5Ks5v0y4B24UAE+7tfD8 Od1FlMDNt4E5lecuGiweskADMt7sU1e5bjLgBhc7Men+wTBiUHtCziK/zcN2gZm9V0 eHFbrbdaP1cXQ29jjaMOmwsSjgYCeBAXa8xhP9MA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Mark Brown , Sasha Levin Subject: [PATCH 4.14 125/161] spi: st-ssc4: add missed pm_runtime_disable Date: Sun, 29 Dec 2019 18:19:33 +0100 Message-Id: <20191229162436.693134986@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162355.500086350@linuxfoundation.org> References: <20191229162355.500086350@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit cd050abeba2a95fe5374eec28ad2244617bcbab6 ] The driver forgets to call pm_runtime_disable in probe failure and remove. Add the missed calls to fix it. Signed-off-by: Chuhong Yuan Link: https://lore.kernel.org/r/20191118024848.21645-1-hslester96@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-st-ssc4.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-st-ssc4.c b/drivers/spi/spi-st-ssc4.c index a4e43fc19ece..5df01ffdef46 100644 --- a/drivers/spi/spi-st-ssc4.c +++ b/drivers/spi/spi-st-ssc4.c @@ -385,6 +385,7 @@ static int spi_st_probe(struct platform_device *pdev) return 0; clk_disable: + pm_runtime_disable(&pdev->dev); clk_disable_unprepare(spi_st->clk); put_master: spi_master_put(master); @@ -396,6 +397,8 @@ static int spi_st_remove(struct platform_device *pdev) struct spi_master *master = platform_get_drvdata(pdev); struct spi_st *spi_st = spi_master_get_devdata(master); + pm_runtime_disable(&pdev->dev); + clk_disable_unprepare(spi_st->clk); pinctrl_pm_select_sleep_state(&pdev->dev); -- 2.20.1