Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13953276ybl; Mon, 30 Dec 2019 00:59:31 -0800 (PST) X-Google-Smtp-Source: APXvYqxl+H2Sgc7L89cnXZa4psOA3XVAwrxwMlCqWt37ysiUf6BbcRxD/aqlkE61nqjbrKzKWw62 X-Received: by 2002:a9d:402:: with SMTP id 2mr15926945otc.357.1577696370947; Mon, 30 Dec 2019 00:59:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577696370; cv=none; d=google.com; s=arc-20160816; b=iZ+LfeXBRejMhl1ZGSravMqmUF+dno/sBHjvGiyQUPJ07dt0oeVYhQabahfJ/QkSJz gBXDDHuUNh9cjOab7CqwMnbLaNfCLCajWahHVZxgNsh9lONLmU4VT4qeoi6e0XKQJ7ZC p7VWbd8Tco9Dekm7sCnDUduiE7T300jDBaeX394rjIfTDopVXgIV/QfMumxeEdkMV6nt DVQIHu7LaAU95SQ1wib/EhzYpNUoc+eWxZsRscrWtsZ8/NGLinoEXZRi0tUq25LLvvI6 mCdxQ/4sUM+ITeMTNg7XHO5Q6GMJPx8fLUBdlpX52aX+EecCLX7iHzWFk87uNrxGr1q/ 8TkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=Zr+4JfrP+6Lpi07cmtq/RqG0DyEsZjNEED3cLxUIUnE=; b=x4n/0CpJsGI5uggMRu+sIguTNz/5M3JH3Bnzq76karrV5UNj0/lOPKRajYhosq04xZ DpQhb2fsftvkJYTOkyJEHqmGlhHgmUe+rAe1PKEiVR5uT8ocYT9OYEEavpiX4d8wivau kX/6duoTx/Mx+eij6tUu/ON581TtEGrQYEBkBzZ0+kPAVQxWpiNXtrlkeTW4Kk7OOvLl kkxpbDzqLkggGs+4jFSEgjW5eO6z1ohW8hGvrjYIac2pWywR6QAp6KDmq8h/9Il8J1cj iNfQ5fwTrg7omjXpJcXijsA1hz2ahWCs+TqHfZokP3DnK+tWNFzp7Nj4LZy0m0Qkwjj9 Qsqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z1si23370942otq.21.2019.12.30.00.59.08; Mon, 30 Dec 2019 00:59:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727260AbfL3I57 (ORCPT + 99 others); Mon, 30 Dec 2019 03:57:59 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:43856 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727162AbfL3I57 (ORCPT ); Mon, 30 Dec 2019 03:57:59 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 0887C5C749BE4B0CB7FE; Mon, 30 Dec 2019 16:57:57 +0800 (CST) Received: from localhost (10.133.213.239) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 30 Dec 2019 16:57:47 +0800 From: YueHaibing To: , , , , , , , CC: , , , YueHaibing Subject: [PATCH -next] PM / devfreq: imx8m-ddrc: Fix inconsistent IS_ERR and PTR_ERR Date: Mon, 30 Dec 2019 16:47:31 +0800 Message-ID: <20191230084731.15776-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix inconsistent IS_ERR and PTR_ERR in imx8m_ddrc_probe(). Detected using Coccinelle. Signed-off-by: YueHaibing --- drivers/devfreq/imx8m-ddrc.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c index 53df792..bc82d36 100644 --- a/drivers/devfreq/imx8m-ddrc.c +++ b/drivers/devfreq/imx8m-ddrc.c @@ -395,15 +395,27 @@ static int imx8m_ddrc_probe(struct platform_device *pdev) } priv->dram_core = devm_clk_get(dev, "core"); + if (IS_ERR(priv->dram_core)) { + ret = PTR_ERR(priv->dram_core); + dev_err(dev, "failed to fetch core clock: %d\n", ret); + return ret; + } priv->dram_pll = devm_clk_get(dev, "pll"); + if (IS_ERR(priv->dram_pll)) { + ret = PTR_ERR(priv->dram_pll); + dev_err(dev, "failed to fetch pll clock: %d\n", ret); + return ret; + } priv->dram_alt = devm_clk_get(dev, "alt"); + if (IS_ERR(priv->dram_alt)) { + ret = PTR_ERR(priv->dram_alt); + dev_err(dev, "failed to fetch alt clock: %d\n", ret); + return ret; + } priv->dram_apb = devm_clk_get(dev, "apb"); - if (IS_ERR(priv->dram_core) || - IS_ERR(priv->dram_pll) || - IS_ERR(priv->dram_alt) || - IS_ERR(priv->dram_apb)) { - ret = PTR_ERR(priv->devfreq); - dev_err(dev, "failed to fetch clocks: %d\n", ret); + if (IS_ERR(priv->dram_apb)) { + ret = PTR_ERR(priv->dram_apb); + dev_err(dev, "failed to fetch apb clock: %d\n", ret); return ret; } -- 2.7.4