Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Dec 2019 16:37:58 +0100
From:   Krzysztof Kozlowski <krzk@kernel.org>
To:     Benjamin Gaignard <benjamin.gaignard@st.com>
Cc:     gregkh@linuxfoundation.org, robh+dt@kernel.org,
        mark.rutland@arm.com, kgene@kernel.org, hminas@synopsys.com,
        linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, m.szyprowski@samsung.com,
        amelie.delaunay@st.com
Subject: Re: [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2"
 from hsotg node
Message-ID: <20191230153758.GB4918@pi3>
References: <20191219103536.25485-1-benjamin.gaignard@st.com>
 <20191219103536.25485-3-benjamin.gaignard@st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191219103536.25485-3-benjamin.gaignard@st.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 19, 2019 at 11:35:36AM +0100, Benjamin Gaignard wrote:
> Remove "snps,dwc2" from hsotg@12480000 node compatible list because
> "samsung,s3c6400-hsotg" should be enough.

The more detailed compatible is almost always "enough". Some other nodes
also have detailed+generic compatible. In this case there is a driver
matching "snps,dwc2" so why removing it?

Best regards,
Krzysztof

> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
>  arch/arm/boot/dts/exynos3250.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index b016b0b68306..d4866269f4ee 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -362,7 +362,7 @@
>  		};
>  
>  		hsotg: hsotg@12480000 {
> -			compatible = "samsung,s3c6400-hsotg", "snps,dwc2";
> +			compatible = "samsung,s3c6400-hsotg";
>  			reg = <0x12480000 0x20000>;
>  			interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&cmu CLK_USBOTG>;
> -- 
> 2.15.0
>