Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp14390748ybl; Mon, 30 Dec 2019 09:15:05 -0800 (PST) X-Google-Smtp-Source: APXvYqz+Pr03XdjzBEQDvjpd43omWqsrKZgVHyek7m4mmWZmxSjvXsUbttQsIWHFFs5NgIhTWXkN X-Received: by 2002:a05:6830:1402:: with SMTP id v2mr64060083otp.12.1577726105863; Mon, 30 Dec 2019 09:15:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577726105; cv=none; d=google.com; s=arc-20160816; b=MsuW7Y3JX6it4/JEL+4BpPQIbaWjltMii+u2wXw34Iaijh4yxAgtj1SQAUyEy45Tgt Lze1KyGl7+5Ant2YJjcTQEaZMTUfwxPiy5TflmR1eZ8iKrmC/E9VSfi4nTDtIM8KbwXf HEMp8Ev5qgIQP0T/wAXwwUfySYLwZLQ8imghTPeXh4kLpZ86n+MNgtOckGFbE+lH74cM uAmcTJCUoj22kqqh4rMr3NoO9rW+WZ075AdGGdiVDio5sdksSzAwt6qGYjFH+pWi/Xhy /Wp35IGXAmYl5FGpUbxu+oSLx3pwrguazIEsvDqzKBpQEh8xa0gUa0rsSNr0o/c6+0zH 2ECw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=vfY9gt1VRv4/X0oVQUAQ14aFmyEBR70glyliw4eTWK0=; b=Zy8lpH91POGq84RS8S2e5jJ3cR1E70Z/Ey1sJXxzeftmv2IvipSMdijd6SsMsFg0lF hQEJ2iZedgsc77B5P2Ai3xFqXXdbPN6sp+HhY7f85UXfGk0NdHkGrweQU8Uqm00+Qd7Y BDez4zKJzTnR4wJzppXW8BMPTpA3a/tdZ1TSJQWVUK6Y9tv5GcrxE1QmUPfMjxVrdqne T7oNit/Hc0HuivJl0FJQ1ZP+mVRP+kdk0WeKESA6VvOhQO9WzR9FquDioyunDeoLf3j9 es/qejwusS59RrgXaHtvTFuUd4IKKkMnM+M5qB24KUayZc012AzQxjgtQsAoYFqYBqPA Vk4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=d2J7Up1A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u12si23606019otq.51.2019.12.30.09.14.53; Mon, 30 Dec 2019 09:15:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=d2J7Up1A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727441AbfL3RM5 (ORCPT + 99 others); Mon, 30 Dec 2019 12:12:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:43560 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727278AbfL3RM5 (ORCPT ); Mon, 30 Dec 2019 12:12:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vfY9gt1VRv4/X0oVQUAQ14aFmyEBR70glyliw4eTWK0=; b=d2J7Up1AkAeaSH9eb0aAVHuszH vVuZyl1oEPvFh07WOH0jpph/7axI31SQx5D6qQpvGN6FESaC5LNsXfKZJUpg10Pbavau56LX/m5w/ tGnFsdwneHFtNBUo0Xg+8DJ1SfWhMXyrAv5l5MSxj8+xWX8nesma6B/JydCblnNvFGVw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1ilyaW-00044T-Du; Mon, 30 Dec 2019 18:12:16 +0100 Date: Mon, 30 Dec 2019 18:12:16 +0100 From: Andrew Lunn To: Alexander Lobakin Cc: "David S. Miller" , Edward Cree , Vivien Didelot , Florian Fainelli , Hauke Mehrtens , Sean Wang , Matthias Brugger , Jiri Pirko , Eric Dumazet , Paolo Abeni , Jakub Kicinski , Taehee Yoo , Stephen Hemminger , Stanislav Fomichev , Daniel Borkmann , Song Liu , Matteo Croce , Jakub Sitnicki , Paul Blakey , Yoshiki Komachi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH RFC net-next 00/20] net: dsa: add GRO support Message-ID: <20191230171216.GC13569@lunn.ch> References: <20191230143028.27313-1-alobakin@dlink.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191230143028.27313-1-alobakin@dlink.ru> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I mark this as RFC, and there are the key questions for maintainers, > developers, users etc.: > - Do we need GRO support for DSA at all? > - Does this series bring any performance improvements on the > affected systems? Hi Alexander I think these are the two most important questions. Did you do any performance testing for the hardware you have? I personally don't have any of the switches you have made modifications to, so i cannot test these patches. I might be able to add GRO to DSA and EDSA, where i can do some performance testing. Andrew