Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191230084731.15776-1-yuehaibing@huawei.com>
In-Reply-To: <20191230084731.15776-1-yuehaibing@huawei.com>
From:   Chanwoo Choi <chanwoo@kernel.org>
Date:   Tue, 31 Dec 2019 02:35:02 +0900
Message-ID: <CAGTfZH36sbTn++gKq+cQOXAutXQbyjbzZ_0VeU2Y037hWnROqA@mail.gmail.com>
Subject: Re: [PATCH -next] PM / devfreq: imx8m-ddrc: Fix inconsistent IS_ERR
 and PTR_ERR
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Shawn Guo <shawnguo@kernel.org>, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com,
        dl-linux-imx <linux-imx@nxp.com>,
        Linux PM list <linux-pm@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 30, 2019 at 5:58 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix inconsistent IS_ERR and PTR_ERR in imx8m_ddrc_probe().
> Detected using Coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/devfreq/imx8m-ddrc.c | 24 ++++++++++++++++++------
>  1 file changed, 18 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
> index 53df792..bc82d36 100644
> --- a/drivers/devfreq/imx8m-ddrc.c
> +++ b/drivers/devfreq/imx8m-ddrc.c
> @@ -395,15 +395,27 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
>         }
>
>         priv->dram_core = devm_clk_get(dev, "core");
> +       if (IS_ERR(priv->dram_core)) {
> +               ret = PTR_ERR(priv->dram_core);
> +               dev_err(dev, "failed to fetch core clock: %d\n", ret);

If there is no special reason, just use 'get' instead of ' fetch' word.
s/fetch/get

> +               return ret;
> +       }
>         priv->dram_pll = devm_clk_get(dev, "pll");
> +       if (IS_ERR(priv->dram_pll)) {
> +               ret = PTR_ERR(priv->dram_pll);
> +               dev_err(dev, "failed to fetch pll clock: %d\n", ret);

ditto.

> +               return ret;
> +       }
>         priv->dram_alt = devm_clk_get(dev, "alt");
> +       if (IS_ERR(priv->dram_alt)) {
> +               ret = PTR_ERR(priv->dram_alt);
> +               dev_err(dev, "failed to fetch alt clock: %d\n", ret);

ditto.

> +               return ret;
> +       }
>         priv->dram_apb = devm_clk_get(dev, "apb");
> -       if (IS_ERR(priv->dram_core) ||
> -               IS_ERR(priv->dram_pll) ||
> -               IS_ERR(priv->dram_alt) ||
> -               IS_ERR(priv->dram_apb)) {
> -               ret = PTR_ERR(priv->devfreq);
> -               dev_err(dev, "failed to fetch clocks: %d\n", ret);
> +       if (IS_ERR(priv->dram_apb)) {
> +               ret = PTR_ERR(priv->dram_apb);
> +               dev_err(dev, "failed to fetch apb clock: %d\n", ret);

ditto.

>                 return ret;
>         }
>
> --
> 2.7.4
>
>


-- 
Best Regards,
Chanwoo Choi