Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v5 07/19] dt-bindings: soc: tegra-pmc: Add id for Tegra
 PMC 32KHz blink clock
To:     Sowjanya Komatineni <skomatineni@nvidia.com>,
        thierry.reding@gmail.com, jonathanh@nvidia.com, broonie@kernel.org,
        lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        mperttunen@nvidia.com, gregkh@linuxfoundation.org,
        sboyd@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com
Cc:     pdeschrijver@nvidia.com, pgaikwad@nvidia.com, spujar@nvidia.com,
        josephl@nvidia.com, daniel.lezcano@linaro.org,
        mmaddireddy@nvidia.com, markz@nvidia.com,
        devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1576880825-15010-1-git-send-email-skomatineni@nvidia.com>
 <1576880825-15010-8-git-send-email-skomatineni@nvidia.com>
 <c8a847fb-3d23-6e1e-59e2-a2d15b63ce02@gmail.com>
 <b46c21ca-855e-cd81-ab8d-aa96b61ebb56@nvidia.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <9a4a125c-7a39-31c9-4670-4f4a29e18c56@gmail.com>
Date:   Mon, 30 Dec 2019 22:39:44 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.0
MIME-Version: 1.0
In-Reply-To: <b46c21ca-855e-cd81-ab8d-aa96b61ebb56@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

28.12.2019 00:30, Sowjanya Komatineni пишет:
> 
> On 12/22/19 1:55 PM, Dmitry Osipenko wrote:
>> 21.12.2019 01:26, Sowjanya Komatineni пишет:
>>> Tegra PMC has blink functionality that allows 32KHz clock out to
>>> blink pin of the Tegra.
>>>
>>> This patch adds id for this blink clock to use for enabling or
>>> disabling blink output through device tree.
>>>
>>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>> ---
>>>   include/dt-bindings/soc/tegra-pmc.h | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/include/dt-bindings/soc/tegra-pmc.h
>>> b/include/dt-bindings/soc/tegra-pmc.h
>>> index f7c866404456..a99a457471ee 100644
>>> --- a/include/dt-bindings/soc/tegra-pmc.h
>>> +++ b/include/dt-bindings/soc/tegra-pmc.h
>>> @@ -9,7 +9,8 @@
>>>   #define TEGRA_PMC_CLK_OUT_1        0
>>>   #define TEGRA_PMC_CLK_OUT_2        1
>>>   #define TEGRA_PMC_CLK_OUT_3        2
>>> +#define TEGRA_PMC_CLK_BLINK        3
>>>   -#define TEGRA_PMC_CLK_MAX        3
>>> +#define TEGRA_PMC_CLK_MAX        4
>>>     #endif    /* _DT_BINDINGS_SOC_TEGRA_PMC_H */
>>>
>> Could you please explain the reason of separating CLK_OUT and BLINK PMC
>> patches?
> No specific reason just thought to have BLINK as separate patch as its
> different register configuration to have fixed 32Khz clock out.
>>
>> Also, you only documented CLK_OUT clocks in the DT binding and no BLINK.
> missed to add BLINK to dt-binding doc. Will add in v6.

Ok