Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp14747170ybl; Mon, 30 Dec 2019 16:31:43 -0800 (PST) X-Google-Smtp-Source: APXvYqxQLdvy5YjGovL8KRz6wgRJcMAqYBQ5zpvldtiHeGNzupfU89eo8YqM6YFztnmnsDQcfMrZ X-Received: by 2002:a9d:d0b:: with SMTP id 11mr79705863oti.287.1577752303002; Mon, 30 Dec 2019 16:31:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577752302; cv=none; d=google.com; s=arc-20160816; b=n11SF0QtwFT4/VIJLSUGxUgUBorm8ZF4g3VSG0nSZ9YPtWMQL3lIu8oxtECWkBLxuL Z56YEnhqHUlzmci/Y48i/p1dJYGeYi6rNww249tLBHsOHiaJ87XahC2cChz0me4Gg38S RyZHI6OSL5fH4rq3rUtSZ53ZeJMe94Kz8GsDSmO+TlGory31klASQUSZq8WYlnhJfMxT omH0bO4qEb6fTHsWKgVAymvTykfO9yFz7l+yGn8/ICChw5mFX8Igi8VVZFf+j1gp3Ott CmGjr1X/lK/K1iCVFGQpmOkdqZSjeYLlR9qGFiO2lfsW3+s5lt8lBLrUB9qi+j7XUjXg gb1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=q9DgC2JorIRoqJhF31krGorwxtftpf4/q1uLy/wL7Rk=; b=wn4qOdRj/XsIH1+GPM2n3JUQK2VTARgHaXSB0IzSi7oDQj15jjVpCkV5RmZjkRSCsy Q6fY2vEQoeuy0dI4vs5VF9V3+d2L8UnnxuKjN2oZJyRUGSlHRchnXn1yx65ojBByasWC 7kzA1cueyTaXHMtNkbMbv4IyKODX4mRU7Cwa7LDrgPgRo2CxgGzoWNKeH3DpcUgvc71/ VJVWIUt/0jk/M4lRDSP6I7+ikp6ZwcMFkQPFx9qQwkgGEzvq/eOeFmogWdWwmRb6bqwr lgBSw2pzci2UE399S7nAUSTHu27rH+qxe0HqMUCvhLhTOHaNQx4Aqn/c8s9rAkuoLM5/ mAXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="tB/IfDFn"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e3si19372401otr.245.2019.12.30.16.31.31; Mon, 30 Dec 2019 16:31:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="tB/IfDFn"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727834AbfLaAao (ORCPT + 99 others); Mon, 30 Dec 2019 19:30:44 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:46324 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727781AbfLaAao (ORCPT ); Mon, 30 Dec 2019 19:30:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=q9DgC2JorIRoqJhF31krGorwxtftpf4/q1uLy/wL7Rk=; b=tB/IfDFnF3Fh dMnBqp4+ZZmSaDOKLYo4X2z67JeplcAANmUjrQeNCKSiwjYlm2UZctXBCqeMqxpdmTP/ZR72gN0fE Fdyq9rbtfSWEIEab5wB2YRw0ZFs8E3pGLPtiise0oq1f1ZJczZF4TE5DeoZ1s444yjBO8UmqGfcz0 7hPvQ=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1im5Qg-0002nr-Rs; Tue, 31 Dec 2019 00:30:34 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 62549D01A24; Tue, 31 Dec 2019 00:30:34 +0000 (GMT) From: Mark Brown To: Christophe JAILLET Cc: alsa-devel@alsa-project.org, brian.austin@cirrus.com, broonie@kernel.org, Charles Keepax , ckeepax@opensource.cirrus.com, kernel-janitors@vger.kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, Mark Brown , patches@opensource.cirrus.com, Paul.Handrigan@cirrus.com, perex@perex.cz, rf@opensource.cirrus.com, tiwai@suse.com Subject: Applied "ASoC: cs47l92: Simplify error handling code in 'cs47l92_probe()'" to the asoc tree In-Reply-To: <20191226162907.9490-1-christophe.jaillet@wanadoo.fr> Message-Id: X-Patchwork-Hint: ignore Date: Tue, 31 Dec 2019 00:30:34 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: cs47l92: Simplify error handling code in 'cs47l92_probe()' has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.6 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 9ea7a991cc27e9af1099b7a628c0ab210dc70a69 Mon Sep 17 00:00:00 2001 From: Christophe JAILLET Date: Thu, 26 Dec 2019 17:29:07 +0100 Subject: [PATCH] ASoC: cs47l92: Simplify error handling code in 'cs47l92_probe()' If 'madera_init_bus_error_irq()' fails, 'wm_adsp2_remove(&cs47l92->core.adsp[0])' will be called twice. Once in the 'if' block, and once in the error handling path. This is harmless, but one of this call can be axed. Signed-off-by: Christophe JAILLET Acked-by: Charles Keepax Link: https://lore.kernel.org/r/20191226162907.9490-1-christophe.jaillet@wanadoo.fr Signed-off-by: Mark Brown --- sound/soc/codecs/cs47l92.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs47l92.c b/sound/soc/codecs/cs47l92.c index d50f75f3b3e4..536b7d35d6b2 100644 --- a/sound/soc/codecs/cs47l92.c +++ b/sound/soc/codecs/cs47l92.c @@ -1959,10 +1959,8 @@ static int cs47l92_probe(struct platform_device *pdev) goto error_dsp_irq; ret = madera_init_bus_error_irq(&cs47l92->core, 0, wm_adsp2_bus_error); - if (ret != 0) { - wm_adsp2_remove(&cs47l92->core.adsp[0]); + if (ret != 0) goto error_adsp; - } madera_init_fll(madera, 1, MADERA_FLL1_CONTROL_1 - 1, &cs47l92->fll[0]); -- 2.20.1