Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp14907739ybl; Mon, 30 Dec 2019 20:27:48 -0800 (PST) X-Google-Smtp-Source: APXvYqw9a1KeepxBYQVEAmiomda/fhzVk9JQ+52K4hkodJdMmcdLI9i5dv+S6n72AVp3t/rKK+pd X-Received: by 2002:a9d:799a:: with SMTP id h26mr75100928otm.240.1577766468808; Mon, 30 Dec 2019 20:27:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577766468; cv=none; d=google.com; s=arc-20160816; b=TneT0SkaLHOACOh2Sovmr0wvr869dLUHT3My6vQJww7KE8zIw0/1I3r6N/n29Y8hVW rQT7x86N3fkujqulB9IrUvaBzGQhlAC/UFYoFQZl9bxXG5j54ThPtUZgj+wGJegOM2MP dk2hFG83hHXLhibxTUq6epqmcvI8b1E+Jk3xHmLrMc2HzNIwiIuytbTIWtBqxGnAsF+4 +9awTbLccUA+kXTcALk+eDpgzUX+lcROaVEueSi11zHdKidYpC8huO7FqsQXmlL8bJqx MaPjmTS8BlLlsNIoryqKFTQfPZ2t2b7xqWNN4xtThxr2wEppMxkmTRUZJslRH87RT97m cxhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=gGbWKmYjVdCoii8UoWhiz4q8Rn+tg2ycSvJBOmgUlYo=; b=RE5vApBSA+Z7yMQOOlTvj8xabkfK8i4Hc88sj7GtE16fmvmZmoWH81jPom32MJEapZ Ivo3MCrPnV/0WLpLGs9IiAWXBc/Z7LX7ZA25DWlkrENOKByTxCDsR3gt+PdVHinI2OZp myBTqRHMpudhVSlF7WrkH6F6Yk/X6g5K+Ac9NShCsa98wmdTtymRBz3hVNIXQ3DimRX0 oFBTXl9b/TY7M4H0HGmwzPrYbdDsb53OSzP/cKZsdOfciDIyTCGYBlEF1/XMg64/jQrt fJOBqMcjNAr5XptK62eBvKZ+xEdk0J0zmbMc0GsW6g1TV0CdE0PaihSuUsAGphnbEhrY DmmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p21si26616052otr.58.2019.12.30.20.27.36; Mon, 30 Dec 2019 20:27:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726597AbfLaE0z (ORCPT + 99 others); Mon, 30 Dec 2019 23:26:55 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:50474 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbfLaE0y (ORCPT ); Mon, 30 Dec 2019 23:26:54 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 56EF913EF09B8; Mon, 30 Dec 2019 20:26:53 -0800 (PST) Date: Mon, 30 Dec 2019 20:26:52 -0800 (PST) Message-Id: <20191230.202652.128958107020164612.davem@davemloft.net> To: po.liu@nxp.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, vinicius.gomes@intel.com, claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, alexandru.marginean@nxp.com, xiaoliang.yang_1@nxp.com, roy.zang@nxp.com, mingkai.hu@nxp.com, jerry.huang@nxp.com, leoyang.li@nxp.com, ivan.khoronzhuk@linaro.org Subject: Re: [v2,net-next] enetc: add support time specific departure base on the qos etf From: David Miller In-Reply-To: <20191227025547.4452-1-Po.Liu@nxp.com> References: <20191223032618.18205-1-Po.Liu@nxp.com> <20191227025547.4452-1-Po.Liu@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 30 Dec 2019 20:26:53 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Po Liu Date: Fri, 27 Dec 2019 03:12:18 +0000 > v2: > - fix the csum and time specific deaprture return directly if both > offloading enabled The test is in the wrong location. You are testing at run time when packets are being transmitted. Instead, you should test when the configuration change is made which creates the conflict, and disallow the configuration change in such a conflicting case.