Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20191229135548.qu3i3zglezlnndds@pali>
References: <20191220062419.23516-1-namjae.jeon@samsung.com>
 <CGME20191220062733epcas1p31665a3ae968ab8c70d91a3cddf529e73@epcas1p3.samsung.com>
 <20191220062419.23516-3-namjae.jeon@samsung.com> <20191229135548.qu3i3zglezlnndds@pali>
From:   Namjae Jeon <linkinjeon@gmail.com>
Date:   Tue, 31 Dec 2019 22:32:35 +0900
Message-ID: <CAKYAXd9pzpQaHcuAR0N-07csf3rQskGcZU35S2Sj8y70XqgN+Q@mail.gmail.com>
Subject: Re: [PATCH v8 02/13] exfat: add super block operations
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc:     Namjae Jeon <namjae.jeon@samsung.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
        sj1557.seo@samsung.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>> +	if (le16_to_cpu(p_bpb->bsx.vol_flags) & VOL_DIRTY) {
>> +		sbi->vol_flag |= VOL_DIRTY;
>> +		exfat_msg(sb, KERN_WARNING,
>> +			"Volume was not properly unmounted. Some data may be corrupt. Please
>> run fsck.");
>
> Hello, do you have some pointers which fsck tool should user run in this
> case?
Hello,
Only windows recovery tool for now. fsck in fuse-exfat is early stage yet.
So I am preparing exfat-tools included a reliable fsck.

>
>> +	}
>> +
>> +	ret = exfat_create_upcase_table(sb);
>> +	if (ret) {
>> +		exfat_msg(sb, KERN_ERR, "failed to load upcase table");
>> +		goto free_bh;
>> +	}
>> +
>> +	/* allocate-bitmap is only for exFAT */
>
> It looks like that this comment is relict from previous version which
> had also FAT32 code included...
Yes, It is leftover from vfat support in sdfat, Will remove it.

Thanks!