Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20191229140005.qrffmjnmizstjkh4@pali>
References: <20191220062419.23516-1-namjae.jeon@samsung.com>
 <CGME20191220062737epcas1p3c0f9e408640148c9186b84efc6d6658b@epcas1p3.samsung.com>
 <20191220062419.23516-10-namjae.jeon@samsung.com> <20191229140005.qrffmjnmizstjkh4@pali>
From:   Namjae Jeon <linkinjeon@gmail.com>
Date:   Tue, 31 Dec 2019 22:34:04 +0900
Message-ID: <CAKYAXd_KLP_179DA9GbAdHyF=A9G9dnWm5hR4pGqds9OSgJhcw@mail.gmail.com>
Subject: Re: [PATCH v8 09/13] exfat: add misc operations
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc:     Namjae Jeon <namjae.jeon@samsung.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
        sj1557.seo@samsung.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>> +#if (BITS_PER_LONG == 64)
>> +	if (second >= UNIX_SECS_2108) {
>> +		tp->second  = 59;
>> +		tp->minute  = 59;
>> +		tp->hour = 23;
>> +		tp->day  = 31;
>> +		tp->month  = 12;
>> +		tp->year = 127;
>> +		return;
>> +	}
>> +#endif
>
> Hello! Why is this code #if-ed? Kernel supports 64 bit long long
> integers also for 32 bit platforms.
>
> Function parameter struct timespec64 *ts is already 64 bit. so above
> #if-code looks really suspicious.
Right, Will remove it.

Thanks for your review!