Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20191229141108.ufnu6lbu7qvl5oxj@pali>
References: <20191220062419.23516-1-namjae.jeon@samsung.com>
 <CGME20191220062732epcas1p17f3b1066fb4d6496559f349f950e1751@epcas1p1.samsung.com>
 <20191220062419.23516-2-namjae.jeon@samsung.com> <20191229141108.ufnu6lbu7qvl5oxj@pali>
From:   Namjae Jeon <linkinjeon@gmail.com>
Date:   Tue, 31 Dec 2019 22:46:51 +0900
Message-ID: <CAKYAXd8WwMXSAicX=bx5vu=1GdXW0h4Lg_atxtdC7NLLo8E=SA@mail.gmail.com>
Subject: Re: [PATCH v8 01/13] exfat: add in-memory and on-disk structures and headers
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc:     Namjae Jeon <namjae.jeon@samsung.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
        sj1557.seo@samsung.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>> +
>> +#define ATTR_READONLY_LE	cpu_to_le16(0x0001)
>> +#define ATTR_HIDDEN_LE		cpu_to_le16(0x0002)
>> +#define ATTR_SYSTEM_LE		cpu_to_le16(0x0004)
>> +#define ATTR_VOLUME_LE		cpu_to_le16(0x0008)
>> +#define ATTR_SUBDIR_LE		cpu_to_le16(0x0010)
>> +#define ATTR_ARCHIVE_LE		cpu_to_le16(0x0020)
>
> Hello!
>
> This looks like copy-paste code from /* file attributes */ section
> above. What about at least making these macro definitions as?
Yes, will remove unused file attribute macros.
>
>   #define ATTR_READONLY_LE	cpu_to_le16(ATTR_READONLY)
>   #define ATTR_HIDDEN_LE	cpu_to_le16(ATTR_HIDDEN)
>   ...
>
> But main question is, are these _LE definitions needed at all?

>
> Looking at the whole patch series and only ATTR_SUBDIR_LE and
> ATTR_ARCHIVE_LE are used.
>
> Is not it better to use cpu_to_le16(ATTR_READONLY) directly in code and
> do not define duplicate ATTR_READONLY_LE macro at all?
I can change them as you pointed out.

Thanks!
>