Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp15395730ybl; Tue, 31 Dec 2019 07:04:34 -0800 (PST) X-Google-Smtp-Source: APXvYqxdmBFNYfMVdaVRvGrSsXiNTy/GxK6MHY99cEYsNRYMMMmY+73+YmMdeKNqasoNVet3DqEP X-Received: by 2002:aa7:d716:: with SMTP id t22mr78951246edq.195.1577804674551; Tue, 31 Dec 2019 07:04:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577804674; cv=none; d=google.com; s=arc-20160816; b=LVKUaLOwgomJGSbYng8LRp5Mh00Oo3sifzPObOrEuWN9HeJgwsuU1dh7Zj3snSSKLs DJssP6jbt0ZZjAp9wqzu3Ae6r72dmp3L2ec+W6RascnU9zUQpWD92dC4ej1Y4/MxUyKk 2zX+vEe/RxUFttDcze1yTRM5PIQGVJUT0/zZdWPe8PhoBv150oDVFRvHw4DGS41/Csql p5TRpVjj7hmCqlOJlmleIAsOHVHJNmYEF6aV9qpMiwArRGZAQAXtYROOXLN1XMvd7fDV CbnR8C7VscKoiK9gznT1qRuCj2UhMvALmn4ANCCSJr5x9d9NI25L+vfKA5u8EGs7JU5B 0few== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition:mime-version :message-id:subject:cc:to:from:date; bh=REZiy3i9CZdRlCRLz7mHjvxPi1OBWqZUJ8OgbJppwAE=; b=zej0FZ7TaMvOZ9uxa4FS8tOfYzagpCsGFfjY5GfFdJSwr+urV4gzO6nal2i4MR8gjB CJaAyYmbCYwzPem7lGIQ8VYIyeDbt0isl5f6Tzw0SH827P91PSaWhOb/r8dyEnc5/Cuu Dd/JhV1g1+uvJCQHuhF7+hDb6xGPg21gOFx9P9j79uZsu5BX+r1kpQtdF4JfoM6p32IH mjPXgWNZ1ZmUJT8LhOFS/xs9pxEHaeq14WGFcaN+2L+3Yu27Ah5Bv56rdtlAhkPCum3J lDyNj3NudEckscHCw3+FlU5aFEzP1WHXllHt3nC1v2ChWG+qUqX4jIs63Mp2tvEkcu2+ r0Mg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r8si30413205edw.220.2019.12.31.07.04.08; Tue, 31 Dec 2019 07:04:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727064AbfLaPCd (ORCPT + 99 others); Tue, 31 Dec 2019 10:02:33 -0500 Received: from isilmar-4.linta.de ([136.243.71.142]:60318 "EHLO isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726659AbfLaPCc (ORCPT ); Tue, 31 Dec 2019 10:02:32 -0500 X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Received: from light.dominikbrodowski.net (brodo.linta [10.1.0.102]) by isilmar-4.linta.de (Postfix) with ESMTPSA id F3BBC2005E4; Tue, 31 Dec 2019 15:02:30 +0000 (UTC) Received: by light.dominikbrodowski.net (Postfix, from userid 1000) id AC6A920EB0; Tue, 31 Dec 2019 16:02:26 +0100 (CET) Date: Tue, 31 Dec 2019 16:02:26 +0100 From: Dominik Brodowski To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, youling257@gmail.com Subject: [PATCH] early init: open /dev/console with O_LARGEFILE Message-ID: <20191231150226.GA523748@light.dominikbrodowski.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If force_o_largefile() is true, /dev/console used to be opened with O_LARGEFILE. Retain that behaviour. Fixes: 8243186f0cc7 ("fs: remove ksys_dup()") Signed-off-by: Dominik Brodowski diff --git a/init/main.c b/init/main.c index 1ecfd43ed464..d12777775cb0 100644 --- a/init/main.c +++ b/init/main.c @@ -1162,7 +1162,8 @@ void console_on_rootfs(void) unsigned int i; /* Open /dev/console in kernelspace, this should never fail */ - file = filp_open("/dev/console", O_RDWR, 0); + file = filp_open("/dev/console", + O_RDWR | (force_o_largefile() ? O_LARGEFILE : 0), 0); if (IS_ERR(file)) goto err_out;