Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20191231150226.GA523748@light.dominikbrodowski.net>
References: <20191231150226.GA523748@light.dominikbrodowski.net>
From:   youling 257 <youling257@gmail.com>
Date:   Tue, 31 Dec 2019 23:55:35 +0800
Message-ID: <CAOzgRdaaxN+BFnx8p2OabC8E9JgcU2VKM=MeGmn9ecmdhJrfLA@mail.gmail.com>
Subject: Re: [PATCH] early init: open /dev/console with O_LARGEFILE
To:     Dominik Brodowski <linux@dominikbrodowski.net>
Cc:     torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
        viro@zeniv.linux.org.uk
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

test this patch, still can see /system/bin/sh warning.
this patch no help for me.

2019-12-31 23:02 GMT+08:00, Dominik Brodowski <linux@dominikbrodowski.net>:
> If force_o_largefile() is true, /dev/console used to be opened
> with O_LARGEFILE. Retain that behaviour.
>
> Fixes: 8243186f0cc7 ("fs: remove ksys_dup()")
> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
>
> diff --git a/init/main.c b/init/main.c
> index 1ecfd43ed464..d12777775cb0 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -1162,7 +1162,8 @@ void console_on_rootfs(void)
>  	unsigned int i;
>
>  	/* Open /dev/console in kernelspace, this should never fail */
> -	file = filp_open("/dev/console", O_RDWR, 0);
> +	file = filp_open("/dev/console",
> +			  O_RDWR | (force_o_largefile() ? O_LARGEFILE : 0), 0);
>  	if (IS_ERR(file))
>  		goto err_out;
>
>