Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp15750010ybl; Tue, 31 Dec 2019 14:26:18 -0800 (PST) X-Google-Smtp-Source: APXvYqwxkzUslopzjaoEA7f1DF5aIFAmaumpyE1JsAfJ4STv2WPEr+ssqBaA0pa+/vTkWyTy27Sf X-Received: by 2002:a17:906:2db1:: with SMTP id g17mr78386225eji.240.1577831178323; Tue, 31 Dec 2019 14:26:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577831178; cv=none; d=google.com; s=arc-20160816; b=ll+GKsbaQqG/E/CZdQ6uzv26JwizrnrQ7HOPdDaBbmcdzkqeHWcBYPuW96vrH2Zh3D Y2D02Aq0+czar23mwqrYP9qnWd6akL47C3dp2LXjdJO8ZmhkvIsnvq+ogu68lFClcYS9 SsenkY3dub6XjuiiiWad/j4O68mjDClK8Ewb++ObfN5H0ifVC+BRXe5yAEaiwvidmBiQ h75eL4Mt8xySUxT2LthcAex+9Y07lnveBIlRzYY6JjHshkajs+vlybDXS3JIX8uFbq1v 3GAb/7BGt3vdvrQ8Y08fqd3c+Lb/Q1CG9mVT13vWoRcZie+7ISt8MvlZMOaJCRHJJ0Rh l64A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=KlT2jnj7z1iFkAKUNQWbQsSo+TR/YWaOOgSod0k7w7Q=; b=VvYka/OQmlw3KGFCDf3CefnvBNe+k5Ec2q13A3AnzEvoMeiNOpTe8dlYQEq8j//4UX EBazGfDx21RFMaT/OZ5VBN24uFW4f2/LtYEFgm4DJgFrHmaWX13ANv6dChlKXRqipFJo LgDc/1Yz3WyLT8c1AWy4sq5GFVfCqSAXuQ75CyLLmC0tobio/x1G/fhECMPAKQJlA2hg j9r93bd7D9dQ1JSGDGsqFuOXwIvC8yo7YdN573vxZBFDJv6PHT0jKmUjDpKE/oH9fc4p jX037okHD0YFxS9NHhYQesXZcK91C3btNEru7yjq/c5AYd03rtTMjJXel6prvvTh5j8G 2rzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=SDs1XLSX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g18si31720971ejr.358.2019.12.31.14.25.54; Tue, 31 Dec 2019 14:26:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=SDs1XLSX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727161AbfLaWWA (ORCPT + 99 others); Tue, 31 Dec 2019 17:22:00 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:45327 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbfLaWWA (ORCPT ); Tue, 31 Dec 2019 17:22:00 -0500 Received: by mail-ot1-f67.google.com with SMTP id 59so51767007otp.12 for ; Tue, 31 Dec 2019 14:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KlT2jnj7z1iFkAKUNQWbQsSo+TR/YWaOOgSod0k7w7Q=; b=SDs1XLSXb/UhPFICpRz+QEz2jdxJ6mnD5z1RgiUjXl2kSN/SRjY9qdkxJyPAomSFTo 4W9MT/Op5DGfy6j89Y0CN+wSoO62llB4hEsqZe/GklaDrEVyBKPBfqdEaWhDU8nIxLmJ 9G0L5DxAM6OUB020gwJZmEOLfI2umTuE8DSX41pN9b6WJW23421YpX2Wkr4V9QE/5XC1 TzPh49oF7f8lsyZ4X7hp8T26FyBOWgQZPAGfV5pzgheLaoIKmuE6AU6YHebo+rk5XUYQ tjdS2jb/XLEk3L/6NONnK54wVAI1n0emlo3so96l7qP/07/oL/REYGzpBJAAD9H4Sk7W lbSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KlT2jnj7z1iFkAKUNQWbQsSo+TR/YWaOOgSod0k7w7Q=; b=GqE+qlzdfL707OoeBYq5ge9UgGY4euC8YPzla52BQGvX6Re7W4eeEHCmySZc7kEjEG 9w0uI6i/UHWOi8mhsTfaAA0DHo5P0hcJs0ypyYJ+KlYRloqcsSyctRkKWWNB/HIsC2NV yTqm2pnK/owF8Romr4CpD3exqZpad5iyrAIUkVBlF/1zRPC5joU2GRBL2C2H7xoca2v+ bIE/JUmrQKgSZCuT9+sxYxY19jI1YbIt/4pMV9EFXMN46FMHTLoMDUkeru26X7+bbFB1 tP4d56TWb8ogNVpjrNp7PHKGlxN4iqlJzLDFr4KCJifMdT4pVyITQlwu3wsBrhsDAxZF GrhA== X-Gm-Message-State: APjAAAVIXA8WMIgWzDMRxbHf4DfA+g5Dz1ogx4n4xQWLdCEw5eER02HI jOswj/MUy4hEW7NEFAgURBhakZrv8gi8Yvns4ASsRg== X-Received: by 2002:a9d:4e99:: with SMTP id v25mr84887327otk.363.1577830919298; Tue, 31 Dec 2019 14:21:59 -0800 (PST) MIME-Version: 1.0 References: <157773590338.4153451.5898675419563883883.stgit@dwillia2-desk3.amr.corp.intel.com> <20191231014630.GA24942@dhcp-128-65.nay.redhat.com> In-Reply-To: From: Dan Williams Date: Tue, 31 Dec 2019 14:21:48 -0800 Message-ID: Subject: Re: [PATCH] efi: Fix handling of multiple contiguous efi_fake_mem= entries To: Dave Young Cc: Ingo Molnar , Taku Izumi , Michael Weiser , Ard Biesheuvel , Thomas Gleixner , Ingo Molnar , Linux Kernel Mailing List , linux-efi , kexec@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 31, 2019 at 1:11 PM Dan Williams wrote: > Perhaps a prettier way to do this is to push the handling of each > efi_fake_mem entry into a subroutine. However, I notice when a memmap > allocated by efi_memmap_alloc() is replaced by another dynamically > allocated memmap the previous one isn't released. I have a series that > fixes that up as well. Available here: http://lore.kernel.org/r/157782985777.367056.14741265874314204783.stgit@dwillia2-desk3.amr.corp.intel.com