Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp16850431ybl; Wed, 1 Jan 2020 15:31:53 -0800 (PST) X-Google-Smtp-Source: APXvYqxdkAfxPBRaH/c9Joq4VVWLC5HzUCUo4QVKXNKeRGUuIPQg8otIFKxCVSaKmdRCgxJ3VZKn X-Received: by 2002:a9d:7d99:: with SMTP id j25mr74210588otn.226.1577921513434; Wed, 01 Jan 2020 15:31:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577921513; cv=none; d=google.com; s=arc-20160816; b=Wu802Q7BiaVvy8DFvmYHhcYS9FNZm76a7rPnc1bEYsENiuZguf3XFjTtbX/rF1ZNuW ikL756Tj6oREMZBTOsQQmVlkxeIloch91Y5i3Q/qGZQPY2P7yS/GdFjW9SAgdzsHa9Ro plyyLjXJfF1VElPJgFXn8CQtGyfgf2aEVWdnGzA2b708zKdIdPVUjcoXsMzDPwT4ZC+3 mQLLRamWE5Z5XypdG5SGuA+nd0kpsrJNTDpppkP4U/Glht5PGIdDUVLTmgXjAzfVbaBN 2pxGTvidOI61tvzXWq/OXXtl5gGKEbsY4eBk2FR1Gv98xqOew3orP+E/U0MpAAbKvMSS bqOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:reply-to; bh=zKh3va0lCJANBlEH97k9dMjoUS9O4lQPPXBhKWe4mGQ=; b=0Q23cEp1vm93t9adlyYkRwAMMn0LIaKaROlbgT7lV9hlVdr1kLIvjMD3ej9a/HluuJ du7TwTgkXhpNVFPAHuSbHvku1yOfoagB2Hjxo5oKwSj+InbFb5btVpm+Z+BkmTqp/Y7X voYP7UEZw7bGlxeh3QvzrGa0RE3fWc+xD0u2d8pTbXmcdAG6uY6jh9CnFTx7Vk1km7ba /FqVOVmKkccwgQyrasf5gtKOqaMBsn+5WOOy36Mh+OcFjtrf2EURj0/oaLstCND98LZl txTRVeYFC2eLh28+WtU9IZ46a7/sqt7RznUXtiXC/zqtljPl7k5lhCe3mS8QddS7gJrq vTnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c19si19588997oto.129.2020.01.01.15.31.18; Wed, 01 Jan 2020 15:31:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727484AbgAAX0o (ORCPT + 99 others); Wed, 1 Jan 2020 18:26:44 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:34635 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727448AbgAAX0n (ORCPT ); Wed, 1 Jan 2020 18:26:43 -0500 Received: by mail-lf1-f67.google.com with SMTP id l18so20692091lfc.1 for ; Wed, 01 Jan 2020 15:26:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=zKh3va0lCJANBlEH97k9dMjoUS9O4lQPPXBhKWe4mGQ=; b=pcCQ2C57+dY2OHlvtRsg4++pMrlTMT6fWN4Fi7mQr1hBCZk2pXptRLfituY3SVlC6v 5VFbyywByl1mnbuFdp0bDvcxqh+ZoJvjiP8+Q1QpGTD2wOF0zl6pZQzlWaVZ5HBxuFFJ Bi4ka8lMYKY+WXbx01xBbImURDddkRMbQeNz7+H1xMSZna88fnoHS5nS8xjpKiFjesD8 Sg6ZiT/L7pQYJjlq+x8wpYZ0NOKw7D942VNQvYZYBbEHQphvkjwFnpLtIM2KHJlcp2JO oqMupr6hQ/8qUaL+TG9vEtaKxOQUMTvusQWaI1QPN94cXPN+nI7/AblwgtwXRREi+dhM WkjA== X-Gm-Message-State: APjAAAX4CVvc9rJ9IS00+PS0Z7MKLM5tRLozgzg++KWopnUZeNIzGwhs lOEnReg8S4eGekFOZ1aGOMU+cU6PhGM= X-Received: by 2002:a19:4208:: with SMTP id p8mr43965574lfa.160.1577921201361; Wed, 01 Jan 2020 15:26:41 -0800 (PST) Received: from [192.168.1.184] (128-68-70-109.broadband.corbina.ru. [128.68.70.109]) by smtp.gmail.com with ESMTPSA id 140sm22477528lfk.78.2020.01.01.15.26.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jan 2020 15:26:40 -0800 (PST) Reply-To: alex.popov@linux.com Subject: Re: [PATCH v1 1/1] lkdtm/stackleak: Make the stack erasing test more verbose To: Kees Cook Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, notify@kernel.org References: <20191219145416.435508-1-alex.popov@linux.com> <201912301034.5C04DC89@keescook> <5bde4de0-875c-536b-67ec-eafebb8b9ab1@linux.com> <201912301443.9B8F6CA6@keescook> From: Alexander Popov Autocrypt: addr=alex.popov@linux.com; prefer-encrypt=mutual; keydata= mQINBFX15q4BEADZartsIW3sQ9R+9TOuCFRIW+RDCoBWNHhqDLu+Tzf2mZevVSF0D5AMJW4f UB1QigxOuGIeSngfmgLspdYe2Kl8+P8qyfrnBcS4hLFyLGjaP7UVGtpUl7CUxz2Hct3yhsPz ID/rnCSd0Q+3thrJTq44b2kIKqM1swt/F2Er5Bl0B4o5WKx4J9k6Dz7bAMjKD8pHZJnScoP4 dzKPhrytN/iWM01eRZRc1TcIdVsRZC3hcVE6OtFoamaYmePDwWTRhmDtWYngbRDVGe3Tl8bT 7BYN7gv7Ikt7Nq2T2TOfXEQqr9CtidxBNsqFEaajbFvpLDpUPw692+4lUbQ7FL0B1WYLvWkG cVysClEyX3VBSMzIG5eTF0Dng9RqItUxpbD317ihKqYL95jk6eK6XyI8wVOCEa1V3MhtvzUo WGZVkwm9eMVZ05GbhzmT7KHBEBbCkihS+TpVxOgzvuV+heCEaaxIDWY/k8u4tgbrVVk+tIVG 99v1//kNLqd5KuwY1Y2/h2MhRrfxqGz+l/f/qghKh+1iptm6McN//1nNaIbzXQ2Ej34jeWDa xAN1C1OANOyV7mYuYPNDl5c9QrbcNGg3D6gOeGeGiMn11NjbjHae3ipH8MkX7/k8pH5q4Lhh Ra0vtJspeg77CS4b7+WC5jlK3UAKoUja3kGgkCrnfNkvKjrkEwARAQABtCZBbGV4YW5kZXIg UG9wb3YgPGFsZXgucG9wb3ZAbGludXguY29tPokCVwQTAQgAQQIbIwIeAQIXgAULCQgHAwUV CgkICwUWAgMBAAIZARYhBLl2JLAkAVM0bVvWTo4Oneu8fo+qBQJdehKcBQkLRpLuAAoJEI4O neu8fo+qrkgP/jS0EhDnWhIFBnWaUKYWeiwR69DPwCs/lNezOu63vg30O9BViEkWsWwXQA+c SVVTz5f9eB9K2me7G06A3U5AblOJKdoZeNX5GWMdrrGNLVISsa0geXNT95TRnFqE1HOZJiHT NFyw2nv+qQBUHBAKPlk3eL4/Yev/P8w990Aiiv6/RN3IoxqTfSu2tBKdQqdxTjEJ7KLBlQBm 5oMpm/P2Y/gtBiXRvBd7xgv7Y3nShPUDymjBnc+efHFqARw84VQPIG4nqVhIei8gSWps49DX kp6v4wUzUAqFo+eh/ErWmyBNETuufpxZnAljtnKpwmpFCcq9yfcMlyOO9/viKn14grabE7qE 4j3/E60wraHu8uiXJlfXmt0vG16vXb8g5a25Ck09UKkXRGkNTylXsAmRbrBrA3Moqf8QzIk9 p+aVu/vFUs4ywQrFNvn7Qwt2hWctastQJcH3jrrLk7oGLvue5KOThip0SNicnOxVhCqstjYx KEnzZxtna5+rYRg22Zbfg0sCAAEGOWFXjqg3hw400oRxTW7IhiE34Kz1wHQqNif0i5Eor+TS 22r9iF4jUSnk1jaVeRKOXY89KxzxWhnA06m8IvW1VySHoY1ZG6xEZLmbp3OuuFCbleaW07OU 9L8L1Gh1rkAz0Fc9eOR8a2HLVFnemmgAYTJqBks/sB/DD0SuuQINBFX15q4BEACtxRV/pF1P XiGSbTNPlM9z/cElzo/ICCFX+IKg+byRvOMoEgrzQ28ah0N5RXQydBtfjSOMV1IjSb3oc23z oW2J9DefC5b8G1Lx2Tz6VqRFXC5OAxuElaZeoowV1VEJuN3Ittlal0+KnRYY0PqnmLzTXGA9 GYjw/p7l7iME7gLHVOggXIk7MP+O+1tSEf23n+dopQZrkEP2BKSC6ihdU4W8928pApxrX1Lt tv2HOPJKHrcfiqVuFSsb/skaFf4uveAPC4AausUhXQVpXIg8ZnxTZ+MsqlwELv+Vkm/SNEWl n0KMd58gvG3s0bE8H2GTaIO3a0TqNKUY16WgNglRUi0WYb7+CLNrYqteYMQUqX7+bB+NEj/4 8dHw+xxaIHtLXOGxW6zcPGFszaYArjGaYfiTTA1+AKWHRKvD3MJTYIonphy5EuL9EACLKjEF v3CdK5BLkqTGhPfYtE3B/Ix3CUS1Aala0L+8EjXdclVpvHQ5qXHs229EJxfUVf2ucpWNIUdf lgnjyF4B3R3BFWbM4Yv8QbLBvVv1Dc4hZ70QUXy2ZZX8keza2EzPj3apMcDmmbklSwdC5kYG EFT4ap06R2QW+6Nw27jDtbK4QhMEUCHmoOIaS9j0VTU4fR9ZCpVT/ksc2LPMhg3YqNTrnb1v RVNUZvh78zQeCXC2VamSl9DMcwARAQABiQI8BBgBCAAmAhsMFiEEuXYksCQBUzRtW9ZOjg6d 67x+j6oFAl16ErcFCQtGkwkACgkQjg6d67x+j6q7zA/+IsjSKSJypgOImN9LYjeb++7wDjXp qvEpq56oAn21CvtbGus3OcC0hrRtyZ/rC5Qc+S5SPaMRFUaK8S3j1vYC0wZJ99rrmQbcbYMh C2o0k4pSejaINmgyCajVOhUhln4IuwvZke1CLfXe1i3ZtlaIUrxfXqfYpeijfM/JSmliPxwW BRnQRcgS85xpC1pBUMrraxajaVPwu7hCTke03v6bu8zSZlgA1rd9E6KHu2VNS46VzUPjbR77 kO7u6H5PgQPKcuJwQQ+d3qa+5ZeKmoVkc2SuHVrCd1yKtAMmKBoJtSku1evXPwyBzqHFOInk mLMtrWuUhj+wtcnOWxaP+n4ODgUwc/uvyuamo0L2Gp3V5ItdIUDO/7ZpZ/3JxvERF3Yc1md8 5kfflpLzpxyl2fKaRdvxr48ZLv9XLUQ4qNuADDmJArq/+foORAX4BBFWvqZQKe8a9ZMAvGSh uoGUVg4Ks0uC4IeG7iNtd+csmBj5dNf91C7zV4bsKt0JjiJ9a4D85dtCOPmOeNuusK7xaDZc gzBW8J8RW+nUJcTpudX4TC2SGeAOyxnM5O4XJ8yZyDUY334seDRJWtS4wRHxpfYcHKTewR96 IsP1USE+9ndu6lrMXQ3aFsd1n1m1pfa/y8hiqsSYHy7JQ9Iuo9DxysOj22UNOmOE+OYPK48D j3lCqPk= Message-ID: Date: Thu, 2 Jan 2020 02:26:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <201912301443.9B8F6CA6@keescook> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31.12.2019 01:46, Kees Cook wrote: > On Tue, Dec 31, 2019 at 01:20:24AM +0300, Alexander Popov wrote: >> On 30.12.2019 21:37, Kees Cook wrote: >>> Hi! I try to keep the "success" conditions for LKDTM tests to be a >>> system exception, so doing "BUG" on a failure is actually against the >>> design. So, really, a test harness needs to know to check dmesg for the >>> results here. It almost looks like this check shouldn't live in LKDTM, >>> but since it feels like other LKDTM tests, I'm happy to keep it there >>> for now. >> >> Do you mean that you will apply this patch? > > Sorry for my confusing reply! I meant that I don't want to apply the > patch, but I'm find to leave the stackleak check in LKDTM. Kees, I think I see a solution. Would you agree if I use dump_stack() instead of BUG() in case of test failure? That would provide enough info for debugging and would NOT break your design. Thanks, Alexander